Uh oh!
There was an error while loading. Please reload this page.
Making coverage table more responsive - #51
Conversation
Trott
commented
Feb 14, 2017
Thanks for tackling this! /cc @nodejs/website |
mhdawson
left a comment
There was a problem hiding this comment.
Seems like a good idea. LGTM
@CurryKitten can you just confirm that the make coverage target you are working on in core still uses this file (I believe so but just want confirmation)
mhdawson
commented
Feb 15, 2017
I think I've answered my own questions and I think its no since the running summary is not generated yet, so thats ok. Will plan to land this soon. |
PR-URL: #51 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
mhdawson
commented
Feb 15, 2017
Landed as 4818a1c, Will check tomorrow to make sure it looks ok on the browsers that I have. |
sirgallifrey
commented
Feb 15, 2017
Awesome! Hope everything turns out ok! |
| padding: 2px 10px; | ||
| } | ||
| .table-header { font-weight: bold;} | ||
| .table-header { font-weight: bold;} |
There was a problem hiding this comment.
Looks like the space after ; is needed to be consistent.
There was a problem hiding this comment.
Hi @stevemao I need to make another PR now that it has landed or i can just commit to this PR?
There was a problem hiding this comment.
You'll need to make another PR. Honestly, I'm not so sure you need to fix that, although by all means, do so if you want to. (There's another line further down with the same issue, for what it's worth, so probably fix them both.)
Trott
commented
Feb 17, 2017
I am really enjoying browsing the coverage stats on my phone. That is all. |
mhdawson
commented
Feb 17, 2017
Ok, live and looks good, closing. @sirgallifrey thanks ! |
mhdawson
commented
Feb 21, 2017
sirgallifrey
commented
Feb 22, 2017
Wow! Thank you very much @mhdawson! I'm very honored to be mentioned! 😄 |
I made a few modifications on the template to make the table work on mobile devices, here are some screenshots
width: 1920 px
width: 1200 px
width: 880px
width: 692px
width: 320px
