Skip to content

Add support for airline warning and error colors - #130

Merged
arcticicestudio merged 2 commits into
nordtheme:developfrom
axelitus:feature/airline-warn-and-error-color
Apr 15, 2019
Merged

Add support for airline warning and error colors#130
arcticicestudio merged 2 commits into
nordtheme:developfrom
axelitus:feature/airline-warn-and-error-color

Conversation

@axelitus

Copy link
Copy Markdown
Contributor

I noticed there weren't colors defined for the errors and warnings of airline, so I've added those to the airline nord theme.

@axelitus

Copy link
Copy Markdown
ContributorAuthor

Without warninng color:
image

With warning color:
image

Comment threadautoload/airline/themes/nord.vim Outdated
Comment threadautoload/airline/themes/nord.vim Outdated
Comment threadautoload/airline/themes/nord.vim Outdated
Comment threadautoload/airline/themes/nord.vim Outdated
Comment threadautoload/airline/themes/nord.vim Outdated

@arcticicestudioarcticicestudio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @axelitus 👋
Thanks for your contributions and patience 👍

I've been too busy with my "real" life and the development of the official Nord website to work on the massive amount of issues/PRs that were submitted each day for all of Nord's port projects.

Your changes looking good to me except that we should use nord1 instead of nord3 as foreground for warnings for better saturation and visual distinction to the background.
I've added the code change suggestions as comment to this PR.


Release Note Assets

Before

After

@axelitus

Copy link
Copy Markdown
ContributorAuthor

No worries, I know how too busy can feel overwhelming sometimes. I'll take a look at it later today or tomorrow.

axelitus added a commit to axelitus/nord-vim that referenced this pull request Apr 14, 2019
As suggested in the comments of pull request nordtheme#130
@axelitus

Copy link
Copy Markdown
ContributorAuthor

Totally agreed with your comments. It's better with more contrast.

I have added a commit which implements your suggestions.

arcticicestudio
arcticicestudio previously approved these changes Apr 15, 2019
@arcticicestudio

Copy link
Copy Markdown
Contributor

I've rebased your branch on top of the develop branch and resolved the merge conflict and will merge it to deploy it with the next release version 🚀
Thanks again for the PR 👍

@arcticicestudio
arcticicestudio merged commit e85dbe7 into nordtheme:developApr 15, 2019
@axelitus
axelitus deleted the feature/airline-warn-and-error-color branch April 16, 2019 16:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@axelitus@arcticicestudio@svengreb