Uh oh!
There was an error while loading. Please reload this page.
Add support for airline warning and error colors - #130
Conversation
axelitus
commented
Jun 27, 2018
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
arcticicestudio
left a comment
There was a problem hiding this comment.
Hi @axelitus 👋
Thanks for your contributions and patience 👍
I've been too busy with my "real" life and the development of the official Nord website to work on the massive amount of issues/PRs that were submitted each day for all of Nord's port projects.
Your changes looking good to me except that we should use nord1 instead of nord3 as foreground for warnings for better saturation and visual distinction to the background.
I've added the code change suggestions as comment to this PR.
Release Note Assets
axelitus
commented
Apr 14, 2019
No worries, I know how too busy can feel overwhelming sometimes. I'll take a look at it later today or tomorrow. |
As suggested in the comments of pull request nordtheme#130
axelitus
commented
Apr 14, 2019
Totally agreed with your comments. It's better with more contrast. I have added a commit which implements your suggestions. |
As suggested in the comments of pull request nordtheme#130
b6dd55c to
2a633e2Comparearcticicestudio
commented
Apr 15, 2019
I've rebased your branch on top of the |




I noticed there weren't colors defined for the errors and warnings of airline, so I've added those to the airline nord theme.