Skip to content

add support for Lsp codelens - #266

Merged
arcticicestudio merged 4 commits into
nordtheme:developfrom
jan-xyz:patch-1
Sep 5, 2021
Merged

add support for Lsp codelens#266
arcticicestudio merged 4 commits into
nordtheme:developfrom
jan-xyz:patch-1

Conversation

@jan-xyz

@jan-xyzjan-xyz commented Jul 10, 2021

Copy link
Copy Markdown
Contributor

code lenses are currently highlighted with the default color. This change adjusts it to make it less visually intrusive like comments. docs: https://neovim.io/doc/user/lsp.html#hl-LspCodeLens

Before:
125170561-cc6aa680-e1af-11eb-9a21-98bbdd62e821

After:
Screenshot 2021-07-10 at 19 28 57

It is based on the VS code highlighting:
Screenshot 2021-07-10 at 19 10 09

code lenses are currently highlighted with the default color. This change adjusts it to make it less visually intrusive like comments. It is based on the VS code highlighting.
@arcticicestudio

Copy link
Copy Markdown
Contributor

Hi @jan-xyz 👋, thanks for your contribution 👍
I'll try to test and review the changes this weekend.

@arcticicestudioarcticicestudio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution. I've added a small improvement suggestion, otherwise this looks good to me 👍🏻

Comment threadcolors/nord.vim Outdated
@jan-xyz

Copy link
Copy Markdown
ContributorAuthor

Done! :) Thanks for the feedback! Would you appreciate another PR that moves other Comments to the custom group as well?

@jan-xyz

Copy link
Copy Markdown
ContributorAuthor

hey @arcticicestudio, any news on getting this merged? 😊

@arcticicestudioarcticicestudio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, I was on vacation for the last few weeks and I deliberately ignored the "digital life" during this time 😄

I reconsidered my previous suggestion and have come to the conclusion that the Comment the group is not right there due to the s:italicize_comments variable. Users who enabled this option would see code lenses being rendered with italic font style for an element that is more or less part of the UI and not the syntax. I guess for now we should use the dedicated definition from your initial PR commit and remove the s:italicize_comments variable. We can introduce a new custom highlighting group for elements like this later on. Sorry for this back and forth of changes 🙈

Would you appreciate another PR that moves other Comments to the custom group as well?

A PR that adds a new custom group for UI elements like code lenses or linter messages (like mentioned above) would be very welcome.

@jan-xyz

Copy link
Copy Markdown
ContributorAuthor

No need to apologize! I appreciate consistent behavior and as this is something new I totally understand that you haven't figured out and planned all of the quirks and bits yet! I'll see to it soon and I hope you had a great digital free vacation 🤗

@jan-xyz

Copy link
Copy Markdown
ContributorAuthor

@arcticicestudio I applied your requested changes

@arcticicestudioarcticicestudio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will land in the next release with some other LSP and tree-sitter related improvements 🚀

@arcticicestudio
arcticicestudio merged commit 02ddfad into nordtheme:developSep 5, 2021
arcticicestudio added a commit that referenced this pull request Sep 12, 2021
Support for LSP code lenses
Before LSP code lenses [1] where code lenses were highlighted with the
default color which has been changed to make it less visually intrusive,
like other UI related elements, i.e. messages of linters.
[1]: https://neovim.io/doc/user/lsp.html#lsp-highlight-codelensGH-266
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
@jan-xyz
jan-xyz deleted the patch-1 branch December 1, 2021 13:46
@svengreb

Copy link
Copy Markdown
Member
Release Note Assets

Before

After

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-xyz@arcticicestudio@svengreb