Uh oh!
There was an error while loading. Please reload this page.
Only call exec once per group - #303
Merged
Merged
Conversation
jvoisin
commented
Apr 12, 2022
ContributorAuthor
(I tested this commit locally, unlike the previous one) |
Calls to `exec` are quite expensive, so using string concatenation and a single exec at the end instead of a couple of exec yields a nice startup performance boost.
arcticicestudio
approved these changes
Apr 24, 2022
arcticicestudio pushed a commit
that referenced
this pull request
May 14, 2022
Before the custom `s:hi` function called Vim's `execute` function [1] for each defined attribute which is quite expensive in terms of performance. To improve this the attributes are now concatenate as string and passed to `exec` at the end of the function instead. Co-authored-by: Julien Voisin <jvoisin@google.com> Co-authored-by: Sven Greb <development@svengreb.de> Co-authored-by: Arctic Ice Sudio <development@arcticicestudio.com> [1]: https://vimhelp.org/builtin.txt.html#builtin.txt#execute%28%29GH-303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to
execare quite expensive, so usingstring concatenation and a single exec at the end
instead of a couple of exec yields a nice
startup performance boost.