Uh oh!
There was an error while loading. Please reload this page.
Finalize Yieldstar integration error handling - #41
Closed
djgrant wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 22, 2026
djgrant
commented
Jul 22, 2026
CollaboratorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event.level, ensuring coordination-waiting and every future warning-level event uselogger.warn.process.exit(1)calls with one testable async Commander error boundary that returns the CLI exit status.Review findings addressed
reconciler.coordination.waitingwarning event.Validation
pnpm buildpnpm typecheckpnpm test:once(79 passed, 4 skipped)git diff --checkUpstream release risk (not patched in Notation)
The installed
@yieldstar/sqlite-runtime0.5.0 task queue writesDate.now() + VISIBILITY_WINDOWmilliseconds tovisible_from, while its SQL visibility queries compare that value withstrftime('%s', 'now')Unix seconds. If a worker crashes after taking a task, the task can remain hidden for roughly 55,000 years. This requires an upstream release fix; this PR intentionally contains no Notation patch, workaround, fallback, lease, or refresh path.