Uh oh!
There was an error while loading. Please reload this page.
Conversation
djgrant
marked this pull request as ready for review
July 22, 2026 05:18
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bun:testand standalonenode:testrunners with one Vitest suite that runs unchanged under both Bun and Node.@yieldstar/sqlite-runtime/bunand exercises realbun:sqlite, while Node loads@yieldstar/sqlite-runtime/nodeand exercises realnode:sqlitethroughDatabaseSync.b549356. The suspend test preserves the result-less reply assertion and waits for the killed child to exit before confirming that nothing was emitted.fail-fast: falselets the other runtime finish reporting.@types/bundependencies while retaining the SQLite package's required Bun connector types.Test workflow error propagation
Commit
9ef2520makes the test SDK'striggerAndWaitrethrow workflow error outcomes and always reset its memory event loop. Tests that intentionally produce workflow errors now assert promise rejection explicitly, so failures cannot be silently converted into later assertion misses. The cache-key restart tests retain their exact mock-call assertions and use a stable 10 ms delay instead of racing a 1 ms real timer under parallel Vitest workers.Validation
bun run test:bun: 17 files, 122 passed, 1 pre-existing skip, 0 failedpnpm run test:node: 17 files, 122 passed, 1 pre-existing skip, 0 failedbun run bundle: passed