Uh oh!
There was an error while loading. Please reload this page.
Fix millisecond/second mismatch in SQLite task visibility timeout - #33
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#32
SqliteTaskQueue.process()wrotevisible_fromas a millisecond timestamp while the DAO's visibility queries compared it againststrftime('%s', 'now')(seconds), so a task claimed by a crashed worker stayed hidden ~55,000 years instead of five minutes.Changes:
TaskQueueDao.getNextTask()andgetTaskCount()now take a millisecondnowvalue from JS and compare withvisible_from <= $now, so all values share one unit and one clock.visible_from = 0explicitly (matchingmakeVisible), so the column default no longer matters — existing databases created with the old seconds-based default keep working.SqliteTaskQueuefrom@yieldstar/sqlite-runtimeand added the regression test suggested in the issue: claim a task, advance past the visibility window, and confirm a fresh queue can reclaim it.