Skip to content

Refactor SQL generator - #543

Merged
austindrenski merged 1 commit into
npgsql:devfrom
austindrenski:refactor-sql-generator
Jul 25, 2018
Merged

Refactor SQL generator#543
austindrenski merged 1 commit into
npgsql:devfrom
austindrenski:refactor-sql-generator

Conversation

@austindrenski

@austindrenskiaustindrenski commented Jul 25, 2018

Copy link
Copy Markdown
Contributor
  • Add doc comments
  • Reorganize methods into regions for Generators and Visitors
  • Make new methods virtual for consistency
  • Add [NotNull] to params on new methods for consistency

@austindrenskiaustindrenski self-assigned this Jul 25, 2018
@austindrenski
austindrenskiforce-pushed the refactor-sql-generator branch from 0d7ce91 to d9dc68bCompareJuly 25, 2018 02:44
@austindrenski
austindrenskiforce-pushed the refactor-sql-generator branch 5 times, most recently from 2ca6b57 to 8b3a575CompareJuly 25, 2018 04:18
@austindrenski
austindrenskiforce-pushed the refactor-sql-generator branch from 8b3a575 to ae41afcCompareJuly 25, 2018 04:34
@austindrenskiaustindrenski changed the title Refactor SQL generator before 541Refactor SQL generatorJul 25, 2018
@austindrenski
austindrenski merged commit 94033c0 into npgsql:devJul 25, 2018
@austindrenski
austindrenski deleted the refactor-sql-generator branch July 25, 2018 04:54
@rojiroji added cleanup and removed refactor labels May 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@austindrenski@roji