Uh oh!
There was an error while loading. Please reload this page.
Refactor to use annotation access pattern - #716
Conversation
e78127d to
a9533caCompareUh oh!
There was an error while loading. Please reload this page.
roji
left a comment
There was a problem hiding this comment.
The overall direction is good and makes the good more clean/idiomatic. But please see notes about where the annotations belong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b17fbfd to
e290f96Comparee290f96 to
cbfe6e9Compareaustindrenski
commented
Nov 23, 2018
@roji I took another pass at this with better naming and more specific extension methods (i.e. not on I think it's a step in the right direction, but may still need some refinement. |
roji
left a comment
There was a problem hiding this comment.
It looks close to ready, see my comment about the interfaces.
For the record I don't think there's huge value in this - it does make for a slightly nicer interface to the annotation data, but lots of code is added to support this...
Uh oh!
There was an error while loading. Please reload this page.
e21fe78 to
1101084Compare
I realized while working on #685 that
PostgresExtension,PostgresEnum, andPostgresRangebroke with (what seems like) the standard annotation access patterns used throughout EF Core.