Skip to content

Clean up schemas/annotation interaction - #725

Closed
austindrenski wants to merge 1 commit into
npgsql:devfrom
austindrenski:schema-ranges-follow-up-2
Closed

Clean up schemas/annotation interaction#725
austindrenski wants to merge 1 commit into
npgsql:devfrom
austindrenski:schema-ranges-follow-up-2

Conversation

@austindrenski

Copy link
Copy Markdown
Contributor

Follows #685 and #724 to bring range annotations up to date with enums.

Specifically:

  • Default schema is only considered at generation-time.
  • Simplifies the access patterns for PostgresRange.

- Default schema is only considered at generation-time.
- Simplifies the access patterns for `PostgresRange`.
@austindrenski
austindrenskiforce-pushed the schema-ranges-follow-up-2 branch from 274e6c4 to b33f40eCompareNovember 29, 2018 04:13
@roji

roji commented Nov 29, 2018

Copy link
Copy Markdown
Member

See #685 (comment) for my comments on DefaultSchema binding - whatever is decided there should be done here as well.

@austindrenski

Copy link
Copy Markdown
ContributorAuthor

Closing this branch in favor of the approach taken in #685.

@austindrenski
austindrenski deleted the schema-ranges-follow-up-2 branch December 1, 2018 20:53
@rojiroji added cleanup and removed refactor labels May 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@austindrenski@roji