Skip to content

Sync with EF Core 3.0.0 preview3 - #844

Merged
roji merged 15 commits into
npgsql:devfrom
roji:preview3
Mar 12, 2019
Merged

Sync with EF Core 3.0.0 preview3#844
roji merged 15 commits into
npgsql:devfrom
roji:preview3

Conversation

@roji

@rojiroji commented Mar 7, 2019

Copy link
Copy Markdown
Member

Following on work done by @Brar in #833, this PR brings EFCore.PG up to date with the recently released preview3 on nuget.org.

@austindrenski@YohDeadfall a quick review would be appreciated as we should publish soon. It shouldn't be too hard.

Comment threadglobal.json
"sdk": {
"version": "3.0.100-preview3-010431"
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it for?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It enforces a specific SDK when multiple are available on the path:

https://docs.microsoft.com/dotnet/core/tools/global-json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this basically pins the dotnet SDK being used - without it the latest one is used. I lost a lot of time because I was using a more recent preview4 SDK which had some issues (because I sometimes really need the absolute latest SDK). This makes builds safer and more predictable...

Comment threadsrc/EFCore.PG/Infrastructure/Internal/NpgsqlOptionsExtension.cs Outdated
Brarand others added 13 commits March 8, 2019 12:47
This allows logging of our own non-default options that have been
configured.
The Microsoft.EntityFrameworkCore.Relational.Specification.Tests
package version 3.0.0-preview.19074.3 depends on this prebuild version
of Xunit.net which prohibits upgrading because its version (2.4.1.4059)
is detected as newer than the 2.4.1 release (2.4.1.0) causing compile
errors
Following fc0bb3be3f92548c4a8f2bd5a15b21ab0d052809 in EF Core
Since PostgreSQL has no type which stores the timezone.
Also, ModificationCommandBatch now has a dependencies type
See dotnet/efcore#14698
@roji

roji commented Mar 8, 2019

Copy link
Copy Markdown
MemberAuthor

Push-forced with @YohDeadfall suggestions, @austindrenski waiting on your sign-off.

@Brar

Brar commented Mar 9, 2019

Copy link
Copy Markdown
Member

Is there a reason this (and other pull requests) doesn't show up in the unstable MyGet feed?

From my understanding of /.build/setup_appveyor.ps1 it should?

(The part that is commented out doesn't seem necessary).

It would be helpful for testing if it did.

@roji

roji commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

@austindrenski sorry to badger, but any way for you to do a quick sign-off on this (or let me know if you don't have the time)? I'd really like the release this ASAP...

@roji

roji commented Mar 11, 2019

Copy link
Copy Markdown
MemberAuthor

@Brar I think the work on making Appveyor build PRs was never completed (in some way), and now we have an outstanding PR for switching to Azure Devops instead... Hopefully this will just get merged very soon...

@roji
roji merged commit ba141fd into npgsql:devMar 12, 2019
@roji
roji deleted the preview3 branch March 12, 2019 11:53
@roji

roji commented Mar 12, 2019

Copy link
Copy Markdown
MemberAuthor

@austindrenski I ended up merging this and releasing preview3, hope that's OK.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@roji@Brar@YohDeadfall@austindrenski