Add support for requiring 2fa to publish specific packages. by iarna · Pull Request #11 · npm/cli

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna · 2018-07-13T01:29:45Z

The nrc PR was: npm/npm-registry-client#175

@iarna

Credit: @iarna PR-URL: #11

@iarna

Credit: @iarna

@iarna

Credit: @iarna PR-URL: #11

iarna · 2018-07-13T02:18:24Z

- cb(err, data)
+ return Bluebird.try(() => {
+ params.auth = auth
+ try {


This is super weird and actually what the API for this function is... it throws if it's given a command its never heard of, but ALSO takes an errback that it uses for network errors. I suppose it's not that unreasonable... it's like an argument assertion.
Just with promises it feels much weirder.

ljharb · 2018-07-13T02:22:28Z

Will this status show up in npm show?

zkat · 2018-08-13T21:22:23Z

This stuff is pretty well tested n-r-c side, so I'll just leave it there. We can write tests for it when this gets ported to n-r-f.

This does need to have the access tests updated because of new output (see Travis)

zkat · 2018-08-20T22:26:47Z

This is getting superseded by #2 so I'm gonna close it.

@isaacs

This uses the updated version of gentle-fs which has the binLink method, so that we don't need to fork based on OS, and will always check to ensure that the bin or cmd-shim is a reference into the folder being linked. Also perform a similar check on linked man pages. Fixnpm#11 PR-URL: npm/bin-links#12 Credit: @isaacsClose: npm#12 Reviewed-by: @isaacs

iarna requested a review from a team as a code owner July 13, 2018 01:29

iarna force-pushed the iarna/per-package-2fa branch from c0e5944 to 74e8b00Compare July 13, 2018 02:08

iarna added a commit that referenced this pull request Jul 13, 2018
access: Add support for requiring per-package 2fa
74e8b00
Credit: @iarna PR-URL: #11

iarna added 2 commits July 12, 2018 19:12

npm-registry-client@8.6.0
1a2ba28
Credit: @iarna

access: Add support for requiring per-package 2fa
573ca50
Credit: @iarna PR-URL: #11

iarna force-pushed the iarna/per-package-2fa branch from 74e8b00 to 573ca50Compare July 13, 2018 02:12

iarna changed the title ~~WIP: Add support for requiring 2fa to publish specific packages.~~Add support for requiring 2fa to publish specific packages.Jul 13, 2018

iarna commented Jul 13, 2018
View reviewed changes

zkat force-pushed the release-next branch 2 times, most recently from 614c234 to 322d9c2Compare July 13, 2018 17:46

zkat added semver:minor new backwards-compatible feature security labels Jul 18, 2018

sindresorhus mentioned this pull request Jul 25, 2018
Enable 2FA when publishing a new package sindresorhus/np#288
Closed

zkat closed this Jul 25, 2018

zkat reopened this Jul 26, 2018

zkat closed this Jul 26, 2018

zkat reopened this Jul 26, 2018

zkat force-pushed the release-next branch from 6e68d60 to dbbb75cCompare August 9, 2018 04:06

zkat removed in-progress labels Aug 13, 2018

zkat force-pushed the release-next branch from 05be0f6 to fd3ee16Compare August 16, 2018 20:13

zkat closed this Aug 20, 2018

sarsampath mentioned this pull request Jul 5, 2021
CB() never called error during docker build #3516
Closed
1 task

nlf deleted the iarna/per-package-2fa branch March 28, 2022 16:56

karthida mentioned this pull request Dec 23, 2025
npm outdated suddenly throws a multitude of "Access token expired or revoked. Please try logging in again." notices #8816
Closed

Jah-yee pushed a commit to Jah-yee/cli that referenced this pull request Apr 16, 2026
fix: decrypt token cache before extracting refresh token (npm#11)
adb2cfa

github-actionsBot referenced this pull request in Kevinlee7250/cli Jun 4, 2026
📊 대시보드 데이터 업데이트 (#11)
a899272

github-actionsBot referenced this pull request in Kevinlee7250/cli Jun 30, 2026
🤖 봇 응답 (#11)
cae89ca

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 1, 2026
✅ 수동 게시 완료 (#11)
16da662

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 2, 2026
🔧 자동 수리 완료 (#11)
46f23a4

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 21, 2026
🗑 포스트 delete: 2026-07-21_코인투자1년후솔직한이야기_8cf0cb3b (#11)
b8b7457

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 23, 2026
🔍 구글 색인 상태 리포트 (#11)
ccb9dea

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 23, 2026
🔥 트렌드 선점 후보 갱신 (#11)
c844c1f

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 25, 2026
🔎 AdSense 감사 리포트 (#11)
ceb721a

github-actionsBot referenced this pull request in Kevinlee7250/cli Jul 29, 2026
📅 시리즈 발행 예약 처리 (#11)
0925cf1