chore: replace var with const/let in repo by watilde · Pull Request #119 · npm/cli

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde · 2018-12-14T20:39:50Z

Refs: https://npm.community/t/replace-var-with-let-const/4083

zkat · 2018-12-14T23:31:27Z

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

watilde · 2018-12-15T14:14:44Z

I just splitted into the two here and #120.

aeschright

⭐️

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

This reverts commit c665f35.

@watilde

PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

…pm#134) Previously used dirs::config_dir() which resolves to different paths per OS (~/Library/Application Support/gws on macOS, %APPDATA%\gws on Windows), contradicting the documented ~/.config/gws/ path and causing users to place config files in the wrong location (ref npm#119). Now uses ~/.config/gws/ everywhere with a fallback to the legacy OS-specific path for existing installs. Also consolidates duplicated dirs::config_dir() calls in auth.rs and discovery.rs to use the central config_dir() helper.

…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>

watilde requested a review from a team as a code owner December 14, 2018 20:39

watilde changed the title ~~chore: replace var with const/let~~chore: replace var with const/let in repoDec 14, 2018

chore: replace var with const/let in lib/repo.js
0b1e09e

watilde force-pushed the feature/let-const branch from 0edf0bd to 0b1e09eCompare December 15, 2018 14:10

aeschright approved these changes Jan 7, 2019
View reviewed changes

aeschright changed the base branch from latest to release-nextJanuary 9, 2019 22:06

aeschright merged commit 73a3edf into npm:release-nextJan 9, 2019

aeschright pushed a commit that referenced this pull request Jan 10, 2019
chore: replace var with const/let in lib/repo.js (#119)
c665f35
PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

aeschright added a commit that referenced this pull request Jan 10, 2019
Revert "chore: replace var with const/let in lib/repo.js (#119)"
0bd6291
This reverts commit c665f35.

aeschright pushed a commit that referenced this pull request Jan 18, 2019
chore: replace var with const/let in lib/repo.js (#119)
255d69b
PR-URL: #119 Credit: @watilde Reviewed-By: @aeschright

watilde deleted the feature/let-const branch December 2, 2019 17:06

kevinjm39 mentioned this pull request May 1, 2022
[Snyk] Upgrade make-fetch-happen from 10.0.3 to 10.1.2 kevinjm39/cli#1
Open

CALISOULB mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities CALISOULB/cli#19
Open

This was referenced Nov 30, 2023
[Snyk] Security upgrade npm-registry-fetch from 9.0.0 to 14.0.0 varmakarthik12/cli#28
Closed
[Snyk] Fix for 1 vulnerabilities varmakarthik12/cli#30
Closed
[Snyk] Security upgrade npm-registry-fetch from 9.0.0 to 14.0.0 varmakarthik12/cli#31
Closed

bumplzz69 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities bumplzz69/cli#38
Open

mtdev2 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities mtdev2/cli#91
Open

Bhanditz mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities Bhanditz/cli#29
Open

varmakarthik12 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities varmakarthik12/cli#38
Closed

baby636 mentioned this pull request Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities baby636/cli#62
Open

varmakarthik12 mentioned this pull request Dec 1, 2023
[Snyk] Security upgrade npm-registry-fetch from 9.0.0 to 14.0.0 varmakarthik12/cli#42
Closed

MrBrain295 mentioned this pull request Dec 19, 2023
[Snyk] Fix for 3 vulnerabilities MrBrain295/cli#12
Open

CALISOULB mentioned this pull request Dec 20, 2023
[Snyk] Fix for 1 vulnerabilities CALISOULB/cli#21
Open

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 2, 2026
🤖 봇 응답 (npm#119)
30ad7a9

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 13, 2026
🔧 자동 수리 완료 (npm#119)
24eb7ab

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 8, 2026
🔥 트렌드 선점 후보 갱신 (npm#119)
1539a76