docs: described exit codes in npm-audit docs by emilis-tm · Pull Request #135 · npm/cli

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

emilis-tm · 2019-01-09T10:07:38Z

Background

It was very easy to just append npm audit to my npm test script, because it returns a correct exit status when vulnerabilities are found.

I think the doc page (https://docs.npmjs.com/cli/audit) should tell readers about the exit status. Had to run my own mini-experiment to see if it works the way I expected.

Change

I added a sentence about the exit status to the description block.
I added a section with further description to the page:
- below CONTENT SUBMITTED, because of the order in the DESCRIPTION paragraph,
- felt the need to mention audit-level configuration setting.

@johanneswuerbach

PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

zkat

This looks good! I'd appreciate it if you could rebase this onto latest. You seem to have slurped up a stray commit. I'm otherwise good with merging this 👍

@emilis-tm

PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat · 2019-02-18T22:42:55Z

Merged this one by hand. :) Thank you!

johanneswuerbachand others added 2 commits January 8, 2019 17:43

Handle git branch references correctly (npm#123)
56aceac
PR-URL: npm#123 Credit: @johanneswuerbach Reviewed-By: @aeschright

docs: described exit codes in npm-audit docs
ad77448

emilis-tm requested a review from a team as a code owner January 9, 2019 10:07

aeschright force-pushed the latest branch from 56aceac to ab0f026Compare January 9, 2019 18:41

aeschright added the docs label Jan 22, 2019

zkat approved these changes Jan 28, 2019
View reviewed changes

zkat added the in-progress label Feb 4, 2019

ngraef mentioned this pull request Feb 14, 2019
doc: add --audit-level param #159
Closed

zkat removed the in-progress label Feb 18, 2019

zkat changed the base branch from latest to release-nextFebruary 18, 2019 22:40

Update shrinkwrap.js
fb23059

zkat pushed a commit that referenced this pull request Feb 18, 2019
docs: described exit codes in npm-audit docs
433020e
PR-URL: #135 Credit: @emilis-tm Reviewed-By: @zkat

zkat closed this Feb 18, 2019

kevinjm39 mentioned this pull request May 1, 2022
[Snyk] Upgrade make-fetch-happen from 10.0.3 to 10.1.2 kevinjm39/cli#1
Open

NOUIY mentioned this pull request Jun 29, 2023
[Snyk] Upgrade hosted-git-info from 5.0.0 to 5.2.1 NOUIY/cli#31
Open

kevinjm39 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities kevinjm39/cli#16
Open

CALISOULB mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities CALISOULB/cli#19
Open

varmakarthik12 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities varmakarthik12/cli#30
Closed

bumplzz69 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities bumplzz69/cli#38
Open

mtdev2 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities mtdev2/cli#91
Open

Bhanditz mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities Bhanditz/cli#29
Open

baby636 mentioned this pull request Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities baby636/cli#62
Open

Omrisnyk mentioned this pull request Apr 30, 2024
[Snyk] Security upgrade npm from 5.6.0 to 6.10.1 Omrisnyk/hibernate-demos#85
Open

Omrisnyk mentioned this pull request May 24, 2024
[Snyk] Security upgrade npm from 5.6.0 to 6.10.1 Omrisnyk/hibernate-demos#88
Open

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 6, 2026
📊 대시보드 데이터 업데이트 (npm#135)
6564c04

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 17, 2026
🔧 자동 수리 완료 (npm#135)
519d3b2

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 10, 2026
🔥 트렌드 선점 후보 갱신 (npm#135)
3091582