ls: show installed but unmet peer deps by larsgw · Pull Request #145 · npm/cli

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw · 2019-01-19T23:38:16Z

Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.

This patch makes it so that npm ls does not hide all "missing" peer
deps, but just the ones that are not installed in some way already.

See https://npm.community/t/4770

zkat

Could you please rebase this onto the latest release-next? It looks like you picked up some changelog stuff here by accident. I'm otherwise fine with this patch! Thank you so much, as always, and we'll be including this in the next release. :)

larsgw · 2019-01-28T22:28:58Z

Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone.

Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770

@larsgw

PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

larsgw requested a review from a team as a code owner January 19, 2019 23:38

zkat force-pushed the release-next branch 3 times, most recently from db63b89 to b09bc8cCompare January 23, 2019 18:36

aeschright added the semver:minor new backwards-compatible feature label Jan 23, 2019

zkat approved these changes Jan 28, 2019
View reviewed changes

larsgw added 2 commits January 29, 2019 19:18

test: use Buffer.from
fd7c393

larsgw force-pushed the patch-19 branch from 8d64735 to fd7c393Compare January 29, 2019 18:18

aeschright merged commit 25573e9 into npm:release-nextJan 29, 2019

aeschright pushed a commit that referenced this pull request Feb 14, 2019
ls: show installed but unmet peer deps (#145)
e37c0cd
PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

Mhmonicox mentioned this pull request Feb 15, 2023
[Snyk] Upgrade make-fetch-happen from 10.1.2 to 10.2.1 Mhmonicox/cli#7
Open

Mhmonicox mentioned this pull request Jun 1, 2023
[Snyk] Upgrade make-fetch-happen from 10.1.2 to 10.2.1 Mhmonicox/cli#12
Open

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 3, 2026
🤖 봇 응답 (npm#145)
e60f0b8

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 8, 2026
📊 대시보드 데이터 업데이트 (npm#145)
76d56f3

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 19, 2026
🔧 자동 수리 완료 (npm#145)
8674796

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 11, 2026
🔥 트렌드 선점 후보 갱신 (npm#145)
0001e95