Skip to content

Chore: Do not send user secret in the referer header - #1663

Closed
assapir wants to merge 2 commits into
latestfrom
assapir/redact-password
Closed

Chore: Do not send user secret in the referer header#1663
assapir wants to merge 2 commits into
latestfrom
assapir/redact-password

Conversation

@assapir

Copy link
Copy Markdown

Until now, CLI is sending the command line args in the referer header, which might be logged.

@assapir
assapir requested a review from a teamAugust 12, 2020 10:08
@npm-deploy-user

npm-deploy-user commented Aug 12, 2020

Copy link
Copy Markdown
angular-quickstartapp-largeapp-mediumember-quickstartreact-app
prevcurrentstatusprevcurrentstatusprevcurrentstatusprevcurrentstatusprevcurrentstatus
initial install41s31.1s39.5s36.4s34.5s31s28.1s20.4s33.5s27.7s
repeat install9.6s7.1s8.6s6.7s8.3s5.9s7.7s5.5s9.1s6.7s
with warm cache32.3s24.7s33.8s30.1s31.3s22.8s23.4s17.4s29.1s23.5s
with node_modules9.2s6.3s8.6s5.9s9s5.5s7.8s5.3s9.4s6.2s
with lockfile32.6s23.9s31s26.2s29s23.1s21.7s16.3s27.4s22.4s
with warm cache and node_modules9.3s6.8s7.9s6s8.4s5.4s7.6s5.4s9.2s6.3s
with warm cache and lockfile24.7s18.4s26.3s22s24.3s16.4s17.8s12.4s21.3s17.5s
with node_modules and lockfile10.1s7.3s9.8s7s8.6s6.7s7.8s5.7s9.7s7.2s

darcyclarke
darcyclarke previously requested changes Aug 12, 2020
Comment thread.gitignore Outdated
@assapir
assapir requested review from a team and darcyclarkeAugust 13, 2020 05:27
@rami548

Copy link
Copy Markdown

@natester605natester605 mentioned this pull request Sep 25, 2021
@nlf
nlf deleted the assapir/redact-password branch March 28, 2022 16:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancementnew feature or improvementRelease 6.xwork is associated with a specific npm 6 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@assapir@npm-deploy-user@rami548@ruyadorno@darcyclarke