Clarify usage of bundledDependencies by john-osullivan · Pull Request #192 · npm/cli

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan · 2019-04-24T22:57:30Z

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running `npm install`. Thought this would be a good contribution for future readers.

ljharb · 2019-07-10T23:18:30Z

Landed in f5857e263?

isaacs · 2019-07-10T23:37:02Z

That is correct.

Two call sites in auth_commands.rs and setup_tui.rs used .strip_suffix(".readonly").unwrap(), which panics if a scope URL flagged as is_readonly doesn't end with ".readonly". Replace with .unwrap_or() to gracefully fall back to the original URL rather than crashing on inconsistent discovery data.

john-osullivan requested a review from a team as a code owner April 24, 2019 22:57

isaacs mentioned this pull request Jul 1, 2019
Release: npm@6.10.0 #205
Merged

isaacs closed this Jul 10, 2019

snyk-bot mentioned this pull request Aug 13, 2019
[Snyk] Upgrade npm from 6.6.0 to 6.10.2 devopsred/gaia#4
Open

baby636 mentioned this pull request Jun 23, 2022
[Snyk] Security upgrade update-notifier from 2.5.0 to 6.0.0 baby636/cli#36
Open

thebpc mentioned this pull request Jun 23, 2022
[Snyk] Security upgrade update-notifier from 2.5.0 to 6.0.0 thebpc/cli#48
Open

Bhanditz mentioned this pull request Jun 24, 2022
[Snyk] Security upgrade update-notifier from 2.5.0 to 6.0.0 Bhanditz/cli#25
Open

bumplzz69 mentioned this pull request Jun 24, 2022
[Snyk] Security upgrade update-notifier from 2.5.0 to 6.0.0 bumplzz69/cli#27
Open

mtdev2 mentioned this pull request Jun 24, 2022
[Snyk] Security upgrade update-notifier from 2.5.0 to 6.0.0 mtdev2/cli#82
Open

mtdev2 mentioned this pull request Sep 27, 2022
[Snyk] Fix for 14 vulnerabilities mtdev2/cli#83
Open

This was referenced Sep 29, 2022
[Snyk] Fix for 21 vulnerabilities bumplzz69/cli#28
Open
[Snyk] Fix for 21 vulnerabilities bumplzz69/cli#29
Open
[Snyk] Fix for 21 vulnerabilities bumplzz69/cli#30
Open

bumplzz69 mentioned this pull request Oct 9, 2022
[Snyk] Fix for 21 vulnerabilities bumplzz69/cli#31
Open

snyk-bot mentioned this pull request Oct 9, 2022
[Snyk] Fix for 14 vulnerabilities mtdev2/cli#84
Open

mtdev2 mentioned this pull request Jun 22, 2023
[Snyk] Fix for 1 vulnerabilities mtdev2/cli#87
Open

Bhanditz mentioned this pull request Jun 22, 2023
[Snyk] Fix for 1 vulnerabilities Bhanditz/cli#27
Open

Omrisnyk mentioned this pull request Apr 30, 2024
[Snyk] Security upgrade npm from 5.6.0 to 6.10.1 Omrisnyk/hibernate-demos#85
Open

Omrisnyk mentioned this pull request May 24, 2024
[Snyk] Security upgrade npm from 5.6.0 to 6.10.1 Omrisnyk/hibernate-demos#88
Open

This was referenced Oct 22, 2024
[Snyk] Fix for 55 vulnerabilities Graybar-codespace/cli-3#116
Open
[Snyk] Fix for 36 vulnerabilities Graybar-codespace/cli-3#153
Open

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 7, 2026
🤖 봇 응답 (npm#192)
1e66639

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 17, 2026
📊 blog3 게시 완료 (npm#192)
ead9c7a

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 5, 2026
🔧 자동 수리 완료 (npm#192)
cc7e179

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 17, 2026
🔥 트렌드 선점 후보 갱신 (npm#192)
bb463ad