Uh oh!
There was an error while loading. Please reload this page.
Added ARM64 platform check - #195
Closed
ossdev07 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: ossdev <ossdev@puresoftware.com>
ossdev07
commented
May 13, 2019
ContributorAuthor
Ping @luislobo@aeschright Please, could you look into PR and suggest if anything else is required from my side. |
rhenwood-arm
commented
May 29, 2019
I would be nice for me (as an AArch64 aka Arm64 user) if this small fix was landed. Is there any feedback? |
ossdev07
commented
Jun 10, 2019
ContributorAuthor
Is there any update on the PR status? |
aeschright
commented
Jun 14, 2019
Contributor
Unfortunately, I'm no longer on the project and don't know when PRs will be merged again. Details: https://gist.github.com/aeschright/8ed09cbc2a4aee00fcb4ad35086d76a6 |
ossdev07
commented
Jun 18, 2019
ContributorAuthor
@aeschright Thanks for letting us know. |
Merged
DanielRuf
commented
Jul 6, 2019
Is this already merged? |
ContributorAuthor
Thanks for accepting the PR, it got merged by the raised PR #205 |
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
This was referenced Feb 12, 2024
This was referenced Feb 12, 2024
This was referenced Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the arm64 architecture check in the legacy-platform-all.js test file.