Uh oh!
There was an error while loading. Please reload this page.
npm checks only node.exe and not node on local dir - #200
Closed
rgoulais wants to merge 1 commit into
Closed
Conversation
Npm find local node.exe on windows, but relies on global node installation on linux. Added a test to check for a local installation of node before relying on the system wide installation.
isaacs pushed a commit
that referenced
this pull request
Jun 28, 2019
npm find local node.exe on windows, but relies on global node installation on linux. Added a test to check for a local installation of node before relying on the system wide installation. Close: #200
isaacs pushed a commit
that referenced
this pull request
Jun 29, 2019
npm find local node.exe on windows, but relies on global node installation on linux. Added a test to check for a local installation of node before relying on the system wide installation. Close: #200
Merged
Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
…#200) * fix: select broadest scope instead of all method scopes Discovery Documents list method scopes as alternatives (any one grants access), but passing all of them to yup_oauth2 caused Google to include restrictive scopes like gmail.metadata in the token. The API then enforced that scope's restrictions, blocking query parameters like `q`. Select only the first (broadest) scope from the method's scope list. * fix: filter gmail.metadata from login scopes and remove token cache superset fallback gmail.metadata restricts API behavior (blocks `q` parameter) even when broader scopes are present in the token. Filter it out during login when broader Gmail scopes like gmail.modify or mail.google.com are selected. Also remove the superset fallback in token storage to prevent stale all-scopes tokens from being reused when a narrower scope is requested. * fix: apply select_scope to MCP server code path The MCP server had the same bug as the CLI — passing all method scopes to get_token. Use select_scope to pick only the broadest scope. * style: fix cargo fmt formatting issues --------- Co-authored-by: Justin Poehnelt <jpoehnelt@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Npm find local node.exe on windows, but relies on global node installation on linux. Added a test to check for a local installation of node before relying on the system wide installation.