Support multiple set/get/deletes in npm config by isaacs · Pull Request #2362 · npm/cli

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs · 2020-12-16T00:48:16Z

While digging into #2300, I realized it would be a lot easier if we
could do this:

npm config set email=me@example.com _auth=xxxx

and avoid the whole issue of what gets set first.

Also, why not let npm config get foo bar baz return just the keys
specified?

Also updates the docs, including the statement that npm config set foo
with no value sets it to true, when as far as I can tell, that has
never been the case.

References

npm-deploy-user · 2020-12-16T00:58:14Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	40.9s	✅	39.5s	45.6s	🛑	34.5s	33.1s	✅	28.1s	27.6s	✅	33.5s	37.2s	✅🐌
repeat install	9.6s	3s	✅	8.6s	3.4s	✅	8.3s	2.5s	✅	7.7s	1.5s	✅	9.1s	2.6s	✅
with warm cache	32.3s	23.4s	✅	33.8s	27.1s	✅	31.3s	19.7s	✅	23.4s	15.9s	✅	29.1s	18.6s	✅
with node_modules	9.2s	5.3s	✅	8.6s	4.4s	✅	9s	3.3s	✅	7.8s	1.8s	✅	9.4s	5.5s	✅
with lockfile	32.6s	28.9s	✅	31s	29.9s	✅	29s	23.5s	✅	21.7s	17.9s	✅	27.4s	24.8s	✅
with warm cache and node_modules	9.3s	3.5s	✅	7.9s	4.3s	✅	8.4s	10.8s	🛑	7.6s	1.8s	✅	9.2s	13.3s	🛑
with warm cache and lockfile	24.7s	9.4s	✅	26.3s	11.7s	✅	24.3s	7.3s	✅	17.8s	5.8s	✅	21.3s	7.3s	✅
with node_modules and lockfile	10.1s	4.9s	✅	9.8s	3.9s	✅	8.6s	2.9s	✅	7.8s	1.6s	✅	9.7s	4.8s	✅

nlf

looks good, nice little usability win here 🎉

@isaacs

While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacsClose: #2362 Reviewed-by: @nlf

isaacs requested a review from ruyadorno December 16, 2020 00:48

isaacs requested a review from a team as a code owner December 16, 2020 00:48

isaacs force-pushed the isaacs/config-set-multi branch from 4faf5f3 to 8ccbdf2Compare December 16, 2020 00:51

isaacs force-pushed the isaacs/config-set-multi branch from 8ccbdf2 to 8fd006aCompare December 16, 2020 01:06

darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 16, 2020

isaacs added the semver:minor new backwards-compatible feature label Dec 18, 2020

nlf approved these changes Dec 18, 2020
View reviewed changes

isaacs changed the base branch from latest to release/v7.3.0December 18, 2020 20:25

isaacs closed this Dec 18, 2020

isaacs force-pushed the isaacs/config-set-multi branch from 8fd006a to a9b8bf2Compare December 18, 2020 20:26

ruyadorno mentioned this pull request Dec 18, 2020
deps: upgrade npm to 7.3.0 nodejs/node#36572
Closed

nlf deleted the isaacs/config-set-multi branch March 28, 2022 16:59

Mhmonicox mentioned this pull request Feb 15, 2023
[Snyk] Upgrade node-gyp from 9.0.0 to 9.3.1 Mhmonicox/cli#10
Open

Mary12jo33 mentioned this pull request Jun 29, 2023
[Snyk] Upgrade node-gyp from 9.0.0 to 9.3.1 Mary12jo33/cli#5
Open