test: replace requireInject with t.mock tap api

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳

[ruyadorno]

• Replaces all usage of requireInject with t.mock
• Standardizes usage of tap as: const t = require('tap')
• Fixes some rare cases in which mocks were relying in the fact that
  requireInject placed mocks within the require.cache and made mocks
  available for nested files, this type of scenario now requires an extra
  t.mock declaration in order to define mocks to that nested file.
• Requires a new release of tap, since currently this PR is just relying in a fork to run all tests, ref: Add mock API tapjs/tapjs#698

[darcyclarke]

Blocked: Need to land the change in tap first & then update the dep in package.json

[darcyclarke]

@ruyadorno we need to land this. @isaacs I'm willing to commit resources to get this across the finish line next week, unless you've got any reservations about landing it. I know It probably means cutting a minor of tap but I don't know what the blocker has been other than just getting time to do that - maybe we can get more resources dedicated to tap moving forward(?) ~ especially given that we rely on it so heavily throughout the CLI

[ruyadorno]

We need to update to tap@15 (not yet released at this point in time) and do a second pass of updating all test files, fixing conflicts and migrating new instances of require-inject usage.

I'm removing the Release-Next label to better reflect the current state.

[wraithgar]

Woohoo! This got done in #3069

[ruyadorno]

🥳