Add (failing) reproducible test case for ENOENT error

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

[salomvary]

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

[salomvary]

See also https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/32

[isaacs]

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

[darcyclarke]

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!