fix(docs): update scripts docs by wraithgar · Pull Request #2690 · npm/cli

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

wraithgar · 2021-02-12T23:59:26Z

The lifecycle events section was very out of date, and lots
of other cleanup needed to happen too

References

Closesnpm/statusboard#267

DeeDeeG · 2021-02-13T02:57:30Z

 * `preinstall`
 * `install`
 * `postinstall`
+* `prepare` (links only)


Thanks for the updated documentation... Random person from the community here with a question:
What does "links only" mean here?
Edit: this maybe? https://docs.npmjs.com/cli/v7/commands/npm-link

This is still a WIP PR. This will be fleshed out more as I continue to rewrite this file.
This means symlinks. npm link does use symlinks under the hood, but this also ends up happening for instance when you've installed a package globally.

wraithgar · 2021-02-24T19:12:05Z

Gonna have to cut this refactor off where it stands. It's a marked improvement on what we have. There's lots more to fix here probably but this PR is too old already.

@wraithgar

The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

DeeDeeG reviewed Feb 13, 2021
View reviewed changes

darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Feb 13, 2021

This was referenced Feb 14, 2021
Fixed: npm publish lifecycle order #2636
Closed
fix(preinstall): run preinstall before reify #2713
Closed

Conduitry mentioned this pull request Feb 17, 2021
Publishing with npm@7 publishes incorrect build of compiler sveltejs/svelte#5662
Closed

darcyclarke removed the release: next These items should be addressed in the next release label Feb 18, 2021

wraithgar force-pushed the gar/docs-lifecycle branch from e8726cb to c8a2f9eCompare February 24, 2021 19:11

wraithgar marked this pull request as ready for review February 24, 2021 19:11

wraithgar requested a review from a team as a code owner February 24, 2021 19:11

wraithgar added the release: next These items should be addressed in the next release label Feb 25, 2021

ruyadorno approved these changes Feb 26, 2021
View reviewed changes

fix(docs): update scripts docs
c8b73db
The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgarClose: #2690 Reviewed-by: @ruyadorno

ruyadorno changed the base branch from latest to release/v7.6.1March 4, 2021 20:54

ruyadorno force-pushed the gar/docs-lifecycle branch from c8a2f9e to c8b73dbCompare March 4, 2021 20:54

ruyadorno merged commit c8b73db into release/v7.6.1Mar 4, 2021

This was referenced Mar 4, 2021
Release/v7.6.1 #2825
Merged
deps: upgrade npm to 7.6.1 nodejs/node#37606
Closed

wraithgar deleted the gar/docs-lifecycle branch June 3, 2021 16:24