Get correct npm prefix on all Windows unix shells by isaacs · Pull Request #2789 · npm/cli

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs · 2021-02-26T21:49:49Z

Get correct npm prefix on all Windows unix shells

Set the shebang to /usr/bin/env bash instead of /bin/sh (which might
be dash or some other shell)
Use Unix-style line endings, not Windows-style (Cygwin accepts
either, but mingw bash sometimes objects, and WSL bash always does)
Test against paths using wslpath if available, but still pass win32
paths to node.exe, since it is a Windows binary that only knows how
to handle Windows paths.

This makes npm as installed by the Node.js Windows MSI installer behave
properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git
Bash when posix CLI utilities are exposed to the cmd.exe shell.

The test is not quite as comprehensive as I'd like. It runs on the
various Windows bash implementations if they are found in their expected
locations, skipping any that are not installed. Short of shipping
mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do
much better, however. At least, we can use this test to assist debug
and catch issues on Windows machines (ours or users who report
problems).

isaacs · 2021-02-26T21:59:53Z

Test failure is WSL complaining about no distro being installed.

Windows Subsystem for
Linux has no installed
distributions.
Distributions can be
installed by visiting the
Microsoft Store:
https://aka.ms/wslstore

Guess I have to check for that along with statting the WSL bash file.

isaacs · 2021-02-27T01:32:14Z

One problem with this: running all these bash shells has resulted in an un-deletable folder on my windows machine at test/bin/windows-shims. I'm going to try to clean that up, do not merge until we do so, because the symlink (junction) in that folder makes it really obnoxious when running npm test a second time.

ruyadorno · 2021-03-01T15:50:50Z

Adding "Needs Tests" label to signal it's not ready until the clean up is ready to go 😊

isaacs · 2021-03-01T17:37:44Z

So the locked folder thing, I have no idea why it happened. I can't reproduce it now.

nlf · 2021-03-01T18:56:28Z

isaacs · 2021-03-01T23:52:59Z

This is good now. Passes tests without admin privs, npm script shim working in all windows bashes I could find.

@isaacs

1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacsClose: #2789 Reviewed-by: @nlf

isaacs requested a review from a team as a code owner February 26, 2021 21:49

isaacs force-pushed the isaacs/fix-windows-shell-bins branch from 70f2750 to 5029587Compare February 26, 2021 21:53

isaacs force-pushed the isaacs/fix-windows-shell-bins branch from 5029587 to 284b581Compare February 26, 2021 22:04

isaacs requested review from nlf and wraithgar February 27, 2021 00:45

ruyadorno added the pr: needs tests requires tests before merging label Mar 1, 2021

ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes and removed pr: needs tests requires tests before merging labels Mar 1, 2021

nlf approved these changes Mar 4, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release/v7.6.1March 4, 2021 21:07

ruyadorno force-pushed the isaacs/fix-windows-shell-bins branch from 03eb195 to e69be2aCompare March 4, 2021 21:07

ruyadorno merged commit e69be2a into release/v7.6.1Mar 4, 2021

This was referenced Mar 4, 2021
Release/v7.6.1 #2825
Merged
deps: upgrade npm to 7.6.1 nodejs/node#37606
Closed

nlf deleted the isaacs/fix-windows-shell-bins branch March 28, 2022 17:00