feat(help): refactor npm help/help-search by wraithgar · Pull Request #2859 · npm/cli

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar · 2021-03-11T22:59:42Z

Lots of dead code removed thanks to streamlining of logic.

npm helpnpm <command> and npm help-search are all now separated
concerns, handling their own use cases. help calls help-search as a
last resort, but npm <command> no longer tries to wind its way through
to help-search just to get the basic npm usage displayed.

The did you mean output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

References

Closesnpm/statusboard#277

wraithgar · 2021-03-12T16:22:12Z


 class Access extends BaseCommand {
+ static get description () {
+ return 'Set access level on published packages'


These all now should match the descriptions in the docs for all the commands, which means we are one step away from being able to programmatically generate everything before the longhand "Description" sections of those docs.

wraithgar · 2021-03-12T16:24:33Z

- constructor (npm) {
- this.npm = npm
+const BaseCommand = require('./base-command.js')
+class Docs extends BaseCommand {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:24:52Z

 /* istanbul ignore next - see test/lib/load-all-commands.js */
- get usage () {
- return usageUtil('docs', 'npm docs [<pkgname> [<pkgname> ...]]')
+static get usage () {


I added a test to test/lib/load-all-commands.js that caught this bug. Yay.

wraithgar · 2021-03-12T16:25:40Z

 async helpSearch (args) {
 if (!args.length)
-throw this.usage
+return this.npm.output(this.usage)


Now that this isn't pulling triple duty it can just work like everything else and return usage on no params

wraithgar · 2021-03-12T16:26:20Z

 if (!formatted.trim())
-npmUsage(this.npm, false)
- else {
+ this.npm.output(`No matches in help for: ${args.join(' ')}\n`)


Now that this isn't the usage output for the cli itself we can act in isolation and not have to return usage here.

wraithgar · 2021-03-12T16:27:24Z

- }
+ let section = this.npm.deref(args[0]) || args[0]

- let pref = [1, 5, 7]


The old method would treat the number in the args as a suggestion, there is no need to search everywhere if we are explicitly asking for a given man number. This was the source of most of the streamlining here.

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

wraithgar requested a review from a team as a code owner March 11, 2021 22:59

wraithgar force-pushed the gar/help-search branch 6 times, most recently from 0c9d405 to bf6c3a8Compare March 12, 2021 15:30

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch 2 times, most recently from 2e175cf to 7f6195eCompare March 12, 2021 16:23

wraithgar commented Mar 12, 2021
View reviewed changes

wraithgar force-pushed the gar/help-search branch from 7f6195e to 4dc3de1Compare March 12, 2021 16:31

darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 12, 2021

wraithgar force-pushed the gar/help-search branch from 4dc3de1 to a60c5a8Compare March 17, 2021 19:46

ruyadorno approved these changes Mar 18, 2021
View reviewed changes

ruyadorno changed the base branch from latest to release-nextMarch 18, 2021 20:11

ruyadorno closed this Mar 18, 2021

ruyadorno force-pushed the gar/help-search branch from a60c5a8 to 41facf6Compare March 18, 2021 20:11

ruyadorno merged commit 41facf6 into release-nextMar 18, 2021

This was referenced Mar 23, 2021
Release/v7.7.0 #2922
Merged
deps: upgrade npm to 7.7.0 nodejs/node#37879
Closed

wraithgar deleted the gar/help-search branch November 2, 2021 20:02

Uh oh!

Conversation

wraithgar commented Mar 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wraithgar commented Mar 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wraithgar commented Mar 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wraithgar commented Mar 11, 2021•
edited
Loading

wraithgar commented Mar 11, 2021•
edited
Loading

wraithgar commented Mar 11, 2021•
edited
Loading

wraithgar commented Mar 11, 2021•
edited
Loading