Uh oh!
There was an error while loading. Please reload this page.
chore(config): remove flatOptions references - #2892
Conversation
754fe69 to
30b8a07CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| const { force, silent, loglevel } = opts | ||
| const force = this.npm.config.get('force') | ||
| const silent = this.npm.config.get('silent') | ||
| const loglevel = this.npm.config.get('loglevel') |
There was a problem hiding this comment.
This was a bug, loglevel is not in flatOptions
isaacs
left a comment
There was a problem hiding this comment.
Some gotchas found, but +1 on the change overall.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Iterative change moving us towards a more unified config. No longer pulling config from flatOptions where we don't have to. PR-URL: #2892 Credit: @wraithgarClose: #2892 Reviewed-by: @ruyadorno
Iterative change moving us towards a more unified config. No longer pulling config from flatOptions where we don't have to. PR-URL: #2892 Credit: @wraithgarClose: #2892 Reviewed-by: @ruyadorno
Iterative change moving us towards a more unified config. No longer pulling config from flatOptions where we don't have to. PR-URL: #2892 Credit: @wraithgarClose: #2892 Reviewed-by: @ruyadorno
Iterative change moving us towards a more unified config.
No longer pulling config from flatOptions where we don't have to.
This also moves our tests closer to using a real npm instance by having an interim
mockNpmthat acts like npm where we need it to.Closesnpm/statusboard#280