Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(usage): tie usage to config by wraithgar · Pull Request #2908 · npm/cli · GitHub
Skip to content

fix(usage): tie usage to config - #2908

Merged
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config
Mar 22, 2021
Merged

fix(usage): tie usage to config#2908
wraithgar merged 1 commit into
release-nextfrom
gar/usage-from-config

Conversation

@wraithgar

@wraithgarwraithgar commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.

The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.

References

Related to npm/statusboard#308

Here we can see the brute-force "Just show a really long complicated usage string" approach for our current save-flag situation in use.
Screen Shot 2021-03-19 at 2 12 45 PM

@scope hint example
Screen Shot 2021-03-19 at 2 13 24 PM

Shorthand examples
Screen Shot 2021-03-19 at 2 13 32 PM

Example of using manual usage declaration in the config to show the --no- option instead
Screen Shot 2021-03-19 at 2 14 04 PM

@wraithgar
wraithgar requested a review from a team as a code ownerMarch 19, 2021 19:00
Comment threadtest/lib/utils/config/definition.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from c4145cd to 2c3c747CompareMarch 19, 2021 21:10

Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was not defined yet, and I re-ran the make to generate this file. We should think about automating this make command

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

defaultDescription: '"some default value"',
type: [Number, String],
hint: '<key>',
usage: '--key <key>|--key <key>',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this once we add a config item that has this kind of type to a command's params.

@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from 2c3c747 to eab8246CompareMarch 19, 2021 21:22
@wraithgarwraithgar added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 22, 2021
nlf
nlf approved these changes Mar 22, 2021

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this. generated usage information based on the actual available options is a huge win. added bonus that we're now separating options that are available from usage information, which are indeed two separate concerns

@isaacsisaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. A few suggestions and minor nitpicky fixups, but overall this is exactly the direction we should be going, yes.


Set to `"browser"` to view html help content in the default web browser.

#### `which`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in the make docs that's part of the release process as a final safety net, but some easier way to run it ahead of time would be nice, too, I agree.

Comment threadlib/pack.js Outdated
Comment threadlib/pack.js Outdated
Comment threadlib/fund.js Outdated
Comment threadlib/uninstall.js Outdated
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch 2 times, most recently from 8a7855e to f37bb68CompareMarch 22, 2021 17:08
This starts us down the path of tying the params our commands accept to
their config items. For now it is optional, and not every current
config item would cleanly render if we added them today.
The ones that are added here DO render nicely, and we can iterate from
here. We can also at a later date do the same kind of appraoch with our
positional args.
PR-URL: #2908
Credit: @wraithgarClose: #2908
Reviewed-by: @nlf, @isaacs
@wraithgar
wraithgarforce-pushed the gar/usage-from-config branch from f37bb68 to b876442CompareMarch 22, 2021 17:18
@wraithgar
wraithgar merged commit b876442 into release-nextMar 22, 2021
@wraithgar
wraithgar deleted the gar/usage-from-config branch November 2, 2021 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@isaacs@nlf