Always set npm.command to canonical command name - #2958

Merged
ruyadorno merged 1 commit into
release-nextfrom
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged

Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom
isaacs/set-npm-command-to-canonical-command

Conversation

@isaacs

@isaacsisaacs commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.

References

@isaacs
isaacs requested a review from a team as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed the isaacs/set-npm-command-to-canonical-command branch from ff50a62 to 9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Mar 25, 2021
@ljharb

ljharb commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Is it not useful for things to know whether i typed npm isntall vs npm install?

@wraithgar

wraithgar commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.

@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno changed the base branch from latest to release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed the isaacs/set-npm-command-to-canonical-command branch from 9c935dd to 59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno merged commit 59cf379 into release-nextMar 25, 2021
This was referenced Mar 25, 2021
Merged
Closed
feelepxyz added a commit to dependabot/dependabot-core that referenced this pull request Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz mentioned this pull request Apr 16, 2021
Merged
This was referenced Jun 29, 2021
Open
Open
Open
@nlf
nlf deleted the isaacs/set-npm-command-to-canonical-command branch March 28, 2022 17:00
@snyk-iosnyk-ioBot mentioned this pull request Oct 23, 2024
Open
@coderabbitaicoderabbitaiBot mentioned this pull request Jul 28, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Always set npm.command to canonical command name - #2958
Merged
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Mar 25, 2021
Merged
Always set npm.command to canonical command name#2958
ruyadorno merged 1 commit into
release-nextfrom 
isaacs/set-npm-command-to-canonical-command
Conversation
@isaacs
@isaacsisaacs
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
This ensures that we get a npm_command env set to, eg 'run-script'

instead of the shorthand 'run'.
References
@isaacs
isaacs
requested a review
from a team
as a code ownerMarch 25, 2021 04:20
@isaacs
isaacsforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
ff50a62 to
9c935ddCompareMarch 25, 2021 04:21
@wraithgarwraithgar
added

Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Mar 25, 2021
@ljharb
ljharb
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Is it not useful for things to know whether i typed npm isntall vs npm install?
@wraithgar
wraithgar
commented
Mar 25, 2021

Copy link


Copy Markdown

Contributor
Even if it is, the purpose of that setting is so that things like lifecycle scripts can know what context they're running under. They should not need to also now be aware of all the affordances for typos.
@isaacs@ruyadorno
Always set npm.command to canonical command name
59cf379
This ensures that we get a npm_command env set to, eg 'run-script'
instead of the shorthand 'run'.
PR-URL: #2958
Credit: @isaacsClose: #2958
Reviewed-by: @wraithgar
@ruyadorno
ruyadorno
changed the base branch from
latest
to
release-nextMarch 25, 2021 21:32
@ruyadorno
ruyadornoforce-pushed
the
isaacs/set-npm-command-to-canonical-command
branch
from
9c935dd to
59cf379CompareMarch 25, 2021 21:32
@ruyadorno
ruyadorno
merged commit 59cf379
into
release-nextMar 25, 2021

This was referenced Mar 25, 2021
 Merged

 Closed

feelepxyz added a commit
to dependabot/dependabot-core
that referenced
this pull request
Apr 16, 2021
@feelepxyz
Update npm from 7.7.4 to 7.10.0
a6d3c7f
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md
## v7.10.0 (2021-04-15)
### FEATURES
* [`f9b639eb6`](npm/cli@f9b639e)
[#3052](npm/cli#3052)
feat(bugs): fall back to email if provided
([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
[#3055](npm/cli#3055)
feat(version): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`f1e6743a6`](npm/cli@f1e6743)
`libnpmversion@1.2.0`
* feat(retrieve-tag): retrieve unannotated git tags
* fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
`@npmcl/git@2.0.8`
* fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
[#3069](npm/cli#3069)
`tap@15.0.2`
### DOCUMENTATION
* [`90b61eda9`](npm/cli@90b61ed)
[#3053](npm/cli#3053)
fix(contributing.md): explicitely outline dep updates
([@darcyclarke](https://github.com/darcyclarke))
## v7.9.0 (2021-04-08)
### FEATURES
* [`1f3e88eba`](npm/cli@1f3e88e)
[#3032](npm/cli#3032)
feat(dist-tag): add workspace support
([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
[#3033](npm/cli#3033)
feat(pack): add workspace support
([@wraithgar](https://github.com/wraithgar))
### DEPENDENCIES
* [`ba4f7fea8`](npm/cli@ba4f7fe)
`licensee@8.2.0`
## v7.8.0 (2021-04-01)
### FEATURES
* [`8bcc5d73f`](npm/cli@8bcc5d7)
[#2972](npm/cli#2972)
feat(workspaces): add repo and docs
([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
[#2998](npm/cli#2998)
feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
[#3001](npm/cli#3001)
feat(view): add workspace support
([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
[#3014](npm/cli#3014)
feat(config): add 'envExport' flag
([@isaacs](https://github.com/isaacs))
### BUG FIXES
* [`4c4252348`](npm/cli@4c42523)
[#3016](npm/cli#3016)
fix(usage): specify the key each time for multiples
([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
[#3013](npm/cli#3013)
fix(docs): add workspaces configuration
([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
[#3015](npm/cli#3015)
fix(ERESOLVE): better errors when current is missing
([@isaacs](https://github.com/isaacs))
### DEPENDENCIES
* [`61da39beb`](npm/cli@61da39b)
`@npmcli/config@2.1.0`
* feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
`@npmcli/arborist@2.3.0`:
* [#2896](npm/cli#2896) Provide currentEdge in
ERESOLVE if known, and address self-linking edge case.
* Add/remove dependencies to/from workspaces when set, not root project
* Only reify the portions of the dependency graph identified by the
`workspace` configuration value.
* Do not recursively `chown` the project root path.
## v7.7.6 (2021-03-29)
### BUG FIXES
* [`9dd2ed518`](npm/cli@9dd2ed5)
fix empty newline printed to stderr
([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
[#2973](npm/cli#2973)
fix spelling in workspaces.md file
([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
[#2979](npm/cli#2979)
change 'maxsockets' default value back to 15
([@wallrat](https://github.com/wallrat))
### DEPENDENCIES
* [`a28f89572`](npm/cli@a28f895)
`libnpmversion@1.1.0`
* fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
`npm-packlist@2.1.5`
* fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
`@npmcli/metavuln-calculator@1.1.1`
* fix error auditing package documents with missing dependencies
## v7.7.5 (2021-03-25)
### BUG FIXES
* [`95ba87622`](npm/cli@95ba876)
[#2949](npm/cli#2949)
fix handling manual indexes in `npm help`
([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
[#2958](npm/cli#2958)
always set `npm.command` to canonical command name
([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
[#2964](npm/cli#2964)
fix(config): properly translate user-agent
([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
[#2965](npm/cli#2965)
fix(config): tie save-exact/save-prefix together
([@wraithgar](https://github.com/wraithgar))
### TESTS
* [`97b415287`](npm/cli@97b4152)
[#2959](npm/cli#2959)
add smoke tests
([@ruyadorno](https://github.com/ruyadorno))
@feelepxyzfeelepxyz
mentioned this pull request
Apr 16, 2021
 Merged


This was referenced Jun 29, 2021
 Open

 Open

 Open

@nlf
nlf
deleted the

isaacs/set-npm-command-to-canonical-command

branch
March 28, 2022 17:00
@snyk-iosnyk-ioBot
mentioned this pull request
Oct 23, 2024
 Open

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jul 28, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

release: nextThese items should be addressed in the next releaseRelease 7.xwork is associated with a specific npm 7 releasesemver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@isaacs@ljharb@wraithgar@ruyadorno