Uh oh!
There was an error while loading. Please reload this page.
Release/v7.12.1 - #3224
Merged
Merged
Conversation
* fix(sort): avoid locale-dependent sorting issues
PR-URL: #3206 Credit: @lukehefsonClose: #3206 Reviewed-by: @darcyclarke
These tests periodically fail in CI, 10 milliseconds is very much not enough time to account for fuzziness, and 5 minutes is more than enough precision given the scales of time involved in each test. PR-URL: #3201 Credit: @wraithgarClose: #3201 Reviewed-by: @nlf
PR-URL: #3216 Credit: @mrmlncClose: #3216 Reviewed-by: @darcyclarke
This adds the 'en' locale to all instances of String.localeCompare within the CLI codebase. Tests added for the cases where we're sorting arbitrary user-generated data. The tests rely on the fact that 'ch' sorts after 'd' in the `'sk'` locale, but ahead of `'d'` in the `'en'` locale. To ensure that this is the default behavior if no locale is specified, `LC_ALL=sk` is set in the test environment. Other instances of `localeCompare` sort data that the cli controls, so no tests were added. Re: #2829 PR-URL: #3203 Credit: @isaacsClose: #3203 Reviewed-by: @ruyadorno
The mocked npm now uses all config defaults, ensuring we don't have bugs from the disconnect between our currently heavily mocked tests and reality. Eventually the npm mock will be closer to reality, this moves the needle. PR-URL: #3211 Credit: @wraithgarClose: #3211 Reviewed-by: @ruyadorno
This was working by coincidence in 7.7.6 and before, and broken in the 7.8.0 refactor. Before, it would see there was no "name" in the spec, and then read your local package.json, and from that get a latest tag. So, if you didn't have a package.json in your CWD it would fail with an ENOENT trying to read it. This fixes it for real, so that if you are asking for info from a git spec, it goes ahead and looks for the `latest` tag (or whatever tag you have configured as your default). PR-URL: #3209 Credit: @wraithgarClose: #3209 Reviewed-by: @ruyadorno
ruyadorno
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v7.12.1 (2021-05-10)
BUG FIXES
de49f58f5#3216 fix(contributing): link to proper cli repo (@mrmlnc)1d092144e#3203 fix(packages): locale-agnostic string sorting (@isaacs)0696fca13#3209 fix(view): fix non-registry specs (@wraithgar)71ac93597#3206 chore(github): Convert md issue template to yaml (@lukehefson)6fb386d3b#3201 fix(tests): increase test fuzziness (@wraithgar)f3a662fcd#3211 fix(tests): use config defaults (@wraithgar)DEPENDENCIES
285976fd1@npmcli/arborist@2.4.4f9f24d17clibnpmexec@1.1.1cb9f17499glob@7.1.724b4e4a41ignore-walk@3.0.41eb7e5c7d@npmcli/arborist@2.4.3a6a826067npm-packlist@2.2.2: