Uh oh!
There was an error while loading. Please reload this page.
Release/v7.18.0 - #3434
Merged
Merged
Conversation
`npm link <pkg>` is meant to be used as a way to link a local package to an install tree and it's very surprising to users that it may prune extraneous deps from the project. This change switches the default behavior to avoid pruning deps when reifying the dependencies in npm link. Fixes: #2554 PR-URL: #3399 Credit: @ruyadornoClose: #3399 Reviewed-by: @ljharb, @nlf
- Setup ./packages/* as workspaces - Moved source from: https://github.com/npm/libnpmdiff to ./packages/libnpmdiff - Added CI target for workspaces Relates to: npm/statusboard#362 PR-URL: #3386 Credit: @ruyadornoClose: #3386 Reviewed-by: @wraithgar
No more requiring npm as a singleton. This will now allow us to move forward with the other refactoring we need to always use the npm object itself in tests, not a mocked one. PR-URL: #3388 Credit: @wraithgarClose: #3388 Reviewed-by: @ruyadorno
Also includes a preliminary refactor to consolidate workspace logic now that every command that supports workspaces has it implemented. PR-URL: #3417 Credit: @wraithgarClose: #3417 Reviewed-by: @ruyadorno
PR-URL: #3423 Credit: @gurdigaClose: #3423 Reviewed-by: @ruyadorno
* fix(retrieve-tag): pass match in a way git accepts
* fix: Make file: URLs (mostly) RFC 8909 compliant
npm-package-arg is doing things more properly now so the tests should reflect that PR-URL: #3426 Credit: @wraithgarClose: #3426 Reviewed-by: @ruyadorno
* fix(inventory) handle old and british forms of 'license' * fix: removes [_complete] check to apply correct metadata * ensure node.fsParent is not set to node itself * fix extraneous deps on load-actual
The behavior for installing global versions if found has never been part of npm@7. PR-URL: #3418 Credit: @wraithgarClose: #3418 Reviewed-by: @lukekarrys
* fix: implement cache modes correctly
`npm ls --prod` is currently not omitting devDependencies for configured workspaces, this changes it by properly checking for the tweaked `currentDepth` value instead of root check that was in place. Fixes: #3382 PR-URL: #3429 Credit: @ruyadornoClose: #3429 Reviewed-by: @wraithgar
This adds a new `npxCache` flatOption for libnpmexec to look for to put its `_npx` content. libnpmexec will have to be patched to use that value, and continue to pass `flatOptions.cache` to pacote et al. The `flatOptions.cache` is the one that is intended to be passed down into other modules, as it has the `_cacache` suffix attached. What was happening before was that `npx` was creating a new alternate cache one directory up from where everything else was, and also putting the `_npx` content there. It is possible this is the source of at least some of our "npx doesn't find the right versions" bugs. PR-URL: #3430 Credit: @wraithgarClose: #3430 Reviewed-by: @ruyadorno
* use new npxCache option
This will allow users to specify a folder in which to save their tarballs. PR-URL: #3420 Credit: @wraithgarClose: #3420 Reviewed-by: @ruyadorno
wraithgar
approved these changes
Jun 17, 2021
ruyadorno
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v7.18.0 (2021-06-17)
FEATURES
ae285b391#3408 feat(ls): support--package-lock-onlyflag (@G-Rath)c984fb59c#3420 feat(pack): add pack-destination config (@wraithgar)BUG FIXES
40829ec40#2554#3399 fix(link): do not prune packages (@ruyadorno)102d4e6fb#3417 fix(workspaces): explicitly error in global mode (@wraithgar)993df3041#3423 fix(docs): ls command usage instructions (@gurdiga)dcc13662c#3418 fix(config): update link definition (@wraithgar)b19e56c2e#3382#3429 fix(ls): respect prod config for workspaces (@ruyadorno)c99b8b53c#3430 fix(config): add flatOptions.npxCache (@wraithgar)e5abf2a21#3386 chore(libnpmdiff): added as workspace (@ruyadorno)c6a8734d7#3388 chore(refactor): finish passing npm context (@wraithgar)d16ee452a#3426 chore(tests): use path.resolve (@wraithgar)DEPENDENCIES
6b951c042libnpmversion@1.2.1:de820a021npm-package-arg@8.1.5:16a95c647@npmcli/arborist@2.6.3:d341bd86cmake-fetch-happen@9.0.3:c90612cf5libnpmexec@2.0.0: