Skip to content

Bring in all libnpm modules + arborist as workspaces - #4166

Merged
fritzy merged 19 commits into
release-nextfrom
fritzy/more-workspaces
Dec 16, 2021
Merged

Bring in all libnpm modules + arborist as workspaces#4166
fritzy merged 19 commits into
release-nextfrom
fritzy/more-workspaces

Conversation

@fritzy

@fritzyfritzy commented Dec 12, 2021

Copy link
Copy Markdown
  • Brings in more workspaces to the CLI
    • arborist
    • libnpmaccess
    • libnpmdiff
    • libnpmexec
    • libnpmfund
    • libnpmhook
    • libnpmorg
    • libnpmpack
    • libnpmpublish
    • libnpmsearch
    • libnpmteam
    • libnpmversion
  • Updates tap for all workspaces to tap@15

@ljharb

Copy link
Copy Markdown
Contributor

This seems like it will make bug reports on specific subpackages easily lost in the noise of cli issues :-/ the issues in this repo already seem quite difficult for the cli team to keep up with.

@npm-robot

npm-robot commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@862.503 ±6.8036.846 ±0.0023.106 ±0.0725.563 ±1.013.636 ±0.023.802 ±0.172.976 ±0.0615.565 ±0.212.881 ±0.053.746 ±0.00
#41660.517 ±0.010.489 ±0.010.537 ±0.020.482 ±0.000.495 ±0.010.495 ±0.010.511 ±0.020.508 ±0.010.502 ±0.020.504 ±0.02
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@844.567 ±1.2428.049 ±0.2916.391 ±0.2218.006 ±0.003.465 ±0.023.511 ±0.153.082 ±0.1411.643 ±0.272.858 ±0.053.484 ±0.03
#41660.482 ±0.010.501 ±0.020.505 ±0.010.510 ±0.010.498 ±0.020.491 ±0.010.495 ±0.000.479 ±0.000.504 ±0.000.493 ±0.00

@fritzy
fritzy marked this pull request as ready for review December 14, 2021 22:18
@fritzy
fritzy requested a review from a team as a code ownerDecember 14, 2021 22:18
@darcyclarke

Copy link
Copy Markdown
Contributor

@ljharb reducing the surface area/channels we need to monitor should actually help us to maintain these projects long-term. To your point, we'll definitely be making a push in the New Year to address the current backlog but I think this PR is a step in the right direction.

@wraithgar
wraithgar changed the base branch from latest to release-nextDecember 15, 2021 17:34
@fritzy
fritzyforce-pushed the fritzy/more-workspaces branch from 91d393b to e159d1fCompareDecember 15, 2021 18:06
@fritzy
fritzy merged commit 6f63055 into release-nextDec 16, 2021
@fritzy
fritzy deleted the fritzy/more-workspaces branch December 16, 2021 18:01
fritzy pushed a commit that referenced this pull request Dec 16, 2021
@fritzyfritzy mentioned this pull request Jan 13, 2022
owlstronaut pushed a commit that referenced this pull request Sep 26, 2025
## References
- Related to #4166
- [We've Moved!
🚚](https://github.com/npm/arborist/blob/main/README.md#weve-moved-)
---------
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@fritzy@ljharb@npm-robot@darcyclarke@lukekarrys