Skip to content

deps: agentkeepalive@4.2.0 - #4213

Merged
nlf merged 1 commit into
release-nextfrom
nlf/dep-agentkeepalive-4.2.0
Jan 6, 2022
Merged

deps: agentkeepalive@4.2.0#4213
nlf merged 1 commit into
release-nextfrom
nlf/dep-agentkeepalive-4.2.0

Conversation

@nlf

@nlfnlf commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

according to this issue node-modules/agentkeepalive#57 this update fixes a race condition that could cause timeouts to cause problems. bringing in this update is worth a shot to potentially fix another source of exit handler not called errors.

@nlf
nlf requested a review from a team as a code ownerJanuary 6, 2022 18:10
@npm-robot

Copy link
Copy Markdown
Contributor

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@845.590 ±1.0226.258 ±0.4915.574 ±0.3416.662 ±1.032.421 ±0.012.439 ±0.011.955 ±0.039.896 ±0.252.011 ±0.082.913 ±0.19
#42130.357 ±0.000.378 ±0.000.350 ±0.000.348 ±0.010.378 ±0.000.346 ±0.010.369 ±0.010.348 ±0.010.367 ±0.000.360 ±0.03
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@832.844 ±0.0219.565 ±0.1211.281 ±0.6612.097 ±0.842.229 ±0.012.225 ±0.012.034 ±0.007.593 ±0.011.853 ±0.012.625 ±0.05
#42130.355 ±0.010.357 ±0.020.362 ±0.020.375 ±0.000.379 ±0.010.373 ±0.000.360 ±0.020.357 ±0.010.395 ±0.040.368 ±0.02

@nlf
nlf merged commit 2e27bff into release-nextJan 6, 2022
@nlf
nlf deleted the nlf/dep-agentkeepalive-4.2.0 branch January 6, 2022 22:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nlf@npm-robot@wraithgar