Skip to content

fix(scripts): more complete commit message formatting - #4216

Merged
nlf merged 1 commit into
release-nextfrom
nlf/fix-changelog-commit-message
Jan 6, 2022
Merged

fix(scripts): more complete commit message formatting#4216
nlf merged 1 commit into
release-nextfrom
nlf/fix-changelog-commit-message

Conversation

@nlf

@nlfnlf commented Jan 6, 2022

Copy link
Copy Markdown
Contributor
  • switches from messageHeadline to message to avoid truncated commit messages
  • instead of removing all instances of (#\d+) only removes those which we're adding our own link to
  • wraps package@1.0.0 type patterns in backticks

@nlf
nlf requested a review from a team as a code ownerJanuary 6, 2022 22:46
@nlf
nlfforce-pushed the nlf/fix-changelog-commit-message branch from 4f1f4f7 to 49b3d6fCompareJanuary 6, 2022 22:49
@npm-robot

npm-robot commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@850.914 ±9.8427.025 ±0.1315.905 ±0.0118.305 ±0.782.663 ±0.032.685 ±0.032.144 ±0.0010.558 ±0.092.152 ±0.012.903 ±0.06
#42160.377 ±0.000.382 ±0.000.377 ±0.000.373 ±0.000.377 ±0.000.375 ±0.000.378 ±0.010.376 ±0.000.377 ±0.000.382 ±0.00
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@834.326 ±1.3021.059 ±0.0411.894 ±0.1312.649 ±0.502.464 ±0.022.443 ±0.022.181 ±0.017.951 ±0.032.048 ±0.012.600 ±0.13
#42160.376 ±0.000.380 ±0.000.378 ±0.000.380 ±0.010.375 ±0.000.378 ±0.000.381 ±0.000.402 ±0.020.380 ±0.000.379 ±0.00

@nlf
nlf merged commit 3b93654 into release-nextJan 6, 2022
@nlf
nlf deleted the nlf/fix-changelog-commit-message branch January 6, 2022 23:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nlf@npm-robot@wraithgar@ruyadorno