Uh oh!
There was an error while loading. Please reload this page.
pack: add dryRun option to packDirectory - #47
Merged
Merged
Conversation
Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd. See https://npm.community/t/592?u=larsgw
Move --dry-run logging closer to original position.
zkat
suggested changes
Aug 15, 2018
zkat
left a comment
Contributor
There was a problem hiding this comment.
Thank you! This is great. Could you add a small test to make sure the original problem isn't happening anymore with this change?
larsgw
commented
Aug 15, 2018
ContributorAuthor
It's not the prettiest test: the error message doesn't really work, but I believe that's how |
larsgw
commented
Aug 20, 2018
ContributorAuthor
@zkat, I don't think I can request another review with GitHubs interface, or respond to the first one, but I added a test. |
zkat
approved these changes
Aug 20, 2018
zkat
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thanks a bunch. This is a great bug fix! 🎉
zkat pushed a commit
that referenced
this pull request
Aug 20, 2018
Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd. Fixes: https://npm.community/t/592 PR-URL: #47 Credit: @larsgw Reviewed-By: @zkat
zkat pushed a commit
that referenced
this pull request
Aug 20, 2018
Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd. Fixes: https://npm.community/t/592 PR-URL: #47 Credit: @larsgw Reviewed-By: @zkat
isaacs added a commit
that referenced
this pull request
Aug 5, 2019
FEATURES * [bbcf7b2](npm/hosted-git-info@bbcf7b2) [#46](npm/hosted-git-info#46) [#43](npm/hosted-git-info#43) [#47](npm/hosted-git-info#47) [#44](npm/hosted-git-info#44) Add support for GitLab groups and subgroups ([@mterrel](https://github.com/mterrel), [@isaacs](https://github.com/isaacs), [@ybiquitous](https://github.com/ybiquitous)) BUGFIXES * ([3b1d629](npm/hosted-git-info@3b1d629)) [#48](npm/hosted-git-info#48) fix http protocol using sshurl by default ([@fengmk2](https://github.com/fengmk2)) * [5d4a8d7](npm/hosted-git-info@5d4a8d7) ignore noCommittish on tarball url generation ([@isaacs](https://github.com/isaacs)) * [1692435](npm/hosted-git-info@1692435) use gist tarball url that works for anonymous gists ([@isaacs](https://github.com/isaacs)) * [d5cf830](npm/hosted-git-info@d5cf830) * Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs)) * [e518222](npm/hosted-git-info@e518222) Use LRU cache to prevent unbounded memory consumption ([@iarna](https://github.com/iarna))
This was referenced Nov 30, 2023
antongolub pushed a commit
to antongolub-forks/npm-cli
that referenced
this pull request
May 18, 2024
* chore: bump @npmcli/template-oss from 3.4.2 to 3.4.3 Bumps [@npmcli/template-oss](https://github.com/npm/template-oss) from 3.4.2 to 3.4.3. - [Release notes](https://github.com/npm/template-oss/releases) - [Changelog](https://github.com/npm/template-oss/blob/main/CHANGELOG.md) - [Commits](npm/template-oss@v3.4.2...v3.4.3) --- updated-dependencies: - dependency-name: "@npmcli/template-oss" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: postinstall for dependabot template-oss PR * chore: postinstall for dependabot template-oss PR Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: npm team <ops+robot@npmjs.com> Co-authored-by: Luke Karrys <luke@lukekarrys.com>
koralle pushed a commit
to koralle/npm-cli
that referenced
this pull request
Feb 11, 2026
Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
dryRunoption topackDirectory. This makes it possible to run postscript after the archive has been written to cwd. Something similar could probably be done forpackFromPackage.See https://npm.community/t/592?u=larsgw