fix: remove test coverage map by wraithgar · Pull Request #4862 · npm/cli

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar · 2022-05-05T14:18:08Z

Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.

This PR removes the coverage map and fixes test to cover all lines that
were being missed.

While adding coverage to the npm search codebase multiple unneeded
guards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.

The npm view tests were also refactored to use the real npm object.

npm-robot · 2022-05-05T14:54:07Z

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	69.138 ±12.81	34.720 ±0.03	19.634 ±0.22	22.471 ±1.06	3.118 ±0.06	3.125 ±0.02	2.495 ±0.04	12.810 ±0.03	2.399 ±0.02	3.557 ±0.10
#4862	57.388 ±6.38	34.856 ±0.01	23.270 ±4.77	22.735 ±0.45	3.162 ±0.02	3.118 ±0.01	2.490 ±0.01	12.883 ±0.04	2.490 ±0.03	3.613 ±0.01

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	40.457 ±1.90	26.701 ±0.00	14.346 ±0.08	15.198 ±0.12	2.885 ±0.06	2.845 ±0.01	2.531 ±0.02	9.124 ±0.06	2.323 ±0.00	3.330 ±0.15
#4862	41.998 ±0.26	26.635 ±0.22	14.447 ±0.15	15.424 ±0.28	2.904 ±0.03	2.888 ±0.02	2.578 ±0.01	9.344 ±0.02	2.354 ±0.03	3.269 ±0.04

ruyadorno · 2022-05-05T20:21:09Z

- return []
-}
-
-module.exports = coverageMap


ruyadorno

LGTM 👍

Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.

This reverts commit 48d2db6.

wraithgar requested a review from a team as a code owner May 5, 2022 14:18

wraithgar force-pushed the gar/no-coverage-map branch from 2b9424a to 9be58d5Compare May 5, 2022 14:26

wraithgar force-pushed the gar/no-coverage-map branch 3 times, most recently from 3b70063 to f11fd1bCompare May 5, 2022 20:16

ruyadorno reviewed May 5, 2022
View reviewed changes

Comment threadtest/coverage-map.js
return []
}

module.exports = coverageMap
ruyadornoMay 5, 2022
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet

ruyadorno approved these changes May 5, 2022
View reviewed changes

wraithgar force-pushed the gar/no-coverage-map branch from f11fd1b to eae9637Compare May 5, 2022 20:42

ruyadorno approved these changes May 5, 2022
View reviewed changes

wraithgar changed the title ~~fix: remote test coverage map~~fix: remove test coverage mapMay 7, 2022

wraithgar merged commit 48d2db6 into latestMay 7, 2022

wraithgar deleted the gar/no-coverage-map branch May 7, 2022 16:11

maricarlagumbay1 added a commit to maricarlagumbay1/cli that referenced this pull request May 8, 2022
Revert "fix: remove test coverage map (npm#4862)"
f25e687
This reverts commit 48d2db6.

maricarlagumbay1 mentioned this pull request May 8, 2022
Revert "fix: remove test coverage map" #4869
Closed

wraithgar mentioned this pull request May 11, 2022
Release/v8.10.0 #4884
Merged

npm-cli-bot mentioned this pull request May 11, 2022
deps: upgrade npm to 8.10.0 nodejs/node#43061
Closed

snyk-ioBot mentioned this pull request Oct 22, 2024
[Snyk] Fix for 17 vulnerabilities Graybar-codespace/cli-3#115
Open