Uh oh!
There was an error while loading. Please reload this page.
CI: switch to actions/checkout@v2 - #600
Conversation
mikemimik
left a comment
There was a problem hiding this comment.
Small change to the ci.yml file. The change doesn't need to be reflected in benchmark.yml because we're not using the repo really.
Note to future selves (@npm/cli-team): might be worth removing that git checkout from the yaml.
| steps: | ||
| # Checkout the npm/cli repo | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
The fetch depth defaults to 1 with the new version of actions/checkout. Ordinarily I don't think this would matter, but we've seen some weirdness with depth: 1 checkouts, and I'd rather avoid this for now. We can always adjust this later in the future.
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v2 | |
| with: | |
| fetch-depth: 0 |
There was a problem hiding this comment.
From the docs on actions/checkout
# Number of commits to fetch. 0 indicates all history.
# Default: 1
fetch-depth: ''
XhmikosR
commented
Jan 6, 2020
I don't agree you need this, unless it causes problems, which it shouldn't. |
XhmikosR
commented
Jan 6, 2020
To elaborate more, the whole point of this patch is to make use of the new defaults which includes depth 1, which in turn speeds things up. So, unless this causes a problem, there's no reason to proactively change the defaults. |
mikemimik
commented
Jan 7, 2020
We'll validate the changes don't break things on our release branch, and if they don't we'll pull the changes in :) |
Should speed things up a bit.