Skip to content

fix: unpublish with scoped registry - #6082

Merged
fritzy merged 1 commit into
latestfrom
gar/unpublish-npmrc
Feb 1, 2023
Merged

fix: unpublish with scoped registry#6082
fritzy merged 1 commit into
latestfrom
gar/unpublish-npmrc

Conversation

@wraithgar

@wraithgarwraithgar commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Unpublish now works if you have a scoped registry config

Closes#5685

Unpublish now works if you have a scoped registry config
@wraithgar
wraithgar requested a review from a team as a code ownerJanuary 24, 2023 18:20
nlf
nlf approved these changes Jan 24, 2023
@npm-cli-bot

Copy link
Copy Markdown
Collaborator

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@836.976 ±4.2215.562 ±0.0514.317 ±0.1416.702 ±0.692.637 ±0.032.714 ±0.052.175 ±0.0110.025 ±0.122.127 ±0.023.750 ±0.65
#608242.583 ±2.8315.260 ±0.0714.209 ±0.0816.707 ±0.132.623 ±0.002.657 ±0.012.061 ±0.049.813 ±0.032.114 ±0.033.211 ±0.04
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@825.525 ±0.4412.409 ±0.0311.078 ±0.1011.886 ±0.272.494 ±0.032.399 ±0.002.232 ±0.017.595 ±0.032.089 ±0.014.724 ±2.53
#608228.654 ±4.7812.085 ±0.1411.180 ±0.1511.811 ±0.182.447 ±0.032.462 ±0.012.129 ±0.057.569 ±0.061.986 ±0.012.943 ±0.13

@fritzy
fritzy merged commit 1525a5e into latestFeb 1, 2023
@fritzy
fritzy deleted the gar/unpublish-npmrc branch February 1, 2023 22:07
@github-actionsgithub-actionsBot mentioned this pull request Feb 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] npm unpublish fails if scope is involved

4 participants

@wraithgar@npm-cli-bot@nlf@fritzy