Skip to content

chore: @npmcli/template-oss@4.19.0 - #6807

Merged
lukekarrys merged 4 commits into
latestfrom
lk/template-oss-4.19.0
Sep 15, 2023
Merged

chore: @npmcli/template-oss@4.19.0#6807
lukekarrys merged 4 commits into
latestfrom
lk/template-oss-4.19.0

Conversation

@lukekarrys

@lukekarryslukekarrys commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@lukekarrys
lukekarrys requested a review from a team as a code ownerSeptember 15, 2023 01:47
@lukekarrys

lukekarrys commented Sep 15, 2023

Copy link
Copy Markdown
ContributorAuthor

We should land this because it doesn't make the CI failures worse, but it also doesn't fix the issue with running node scripts/resetdeps.js in Node 14. It is running the correct version of npm for Node 14, but once it drops down to that script there will always be an error due to it using Node 16 only features.

It seems easiest to bump all workspace engines to `^16.14 || >= 18'. @wraithgar what do you think?

@wraithgar

wraithgar commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

I think the npm workspaces are going to have to come along with npm in their engines declarations.

@lukekarrys
fix: set engines to ^16.14.0 || >=18.0.0
06387e9
BREAKING CHANGE: @npmcli/config now supports node ^16.14.0 || >=18.0.0
@lukekarrys
fix: set engines to ^16.14.0 || >=18.0.0
b9e7fa1
BREAKING CHANGE: libnpmfund now supports node ^16.14.0 || >=18.0.0
@lukekarrys

lukekarrys commented Sep 15, 2023

Copy link
Copy Markdown
ContributorAuthor

This should now be rebased. It includes two breaking changes for updating the engines on @npmcli/config and libnpmfund. It also uses template-oss to configure the engines for both so in the future we will be forced to update the workspace engines all at once.

@lukekarrys

lukekarrys commented Sep 15, 2023

Copy link
Copy Markdown
ContributorAuthor

There should be no more expected CI failures in this PR. If any runs fail they should be examined and fixed.

@lukekarrys
chore: set workspace engines
69342ff
This align all private workspaces to the same engines as the CLI
and all public workspaces to ^16.14.0 || >=18.0.0
@lukekarrys
lukekarrys merged commit 0270a7d into latestSep 15, 2023
@lukekarrys
lukekarrys deleted the lk/template-oss-4.19.0 branch September 15, 2023 20:10
@github-actionsgithub-actionsBot mentioned this pull request Sep 15, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukekarrys@wraithgar