Uh oh!
There was an error while loading. Please reload this page.
feat: add --libc option to override platform specific install - #6817
Closed
Brooooooklyn wants to merge 1 commit into
Closed
feat: add --libc option to override platform specific install#6817Brooooooklyn wants to merge 1 commit into
Brooooooklyn wants to merge 1 commit into
Conversation
wraithgar
commented
Sep 18, 2023
Contributor
Would this actually do anything? npm-install-checks doesn't allow overriding of this param currently |
Brooooooklyn
commented
Oct 9, 2023
ContributorAuthor
@wraithgar |
Contributor
We don't typically allow external PRs to update dependencies. #6882 will update the dep then this PR will be able to land. |
Brooooooklyn
commented
Oct 11, 2023
ContributorAuthor
@wraithgar ready again |
wraithgar
commented
Oct 11, 2023
Contributor
Looks like snapshot tests in |
wraithgar
commented
Oct 17, 2023
Contributor
@Brooooooklyn if you don't mind, since this still needs the snapshot update I will pull these changes into a new PR next week so that they can land. I will still give you credit in the commit message. |
Brooooooklyn
commented
Oct 18, 2023
ContributorAuthor
@wraithgar sure! I don’t mind it. Let’s land it asap |
wraithgar
commented
Oct 18, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--cpuand--osoption to override platform specific install #6755