Benchmarks / Contributing Updates by mikemimik · Pull Request #689 · npm/cli

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik · 2020-01-13T17:00:24Z

What / Why

What

Contains an update to benchmarks.yml workflow file that does the following:

removes unnecessary checkout of repository
removes unnecessary setup of nodejs
adds ability to discern if pull-request event is coming from current repository or a forked repository

Contains an additional workflow file benchmarks-comments.yml file which does the following:

detects if the triggering comment came from a pull-request
checks if the comments starts with "test this please ✅"
dispatches a request to get benchmarks (same action taken as benchmarks.yml file)
adds a rocket reaction to the comment the first time triggered

Contains an updated CONTRIBUTING.md file which has updated information about contributing to this project. This includes information about the above mentioned benchmarking for pull-requests.

Why

The reason for benchmarks-comments.yml is because when a pull-request from a forked repository triggers an event, the github action that runs doesn't get scoped with secret content (this is for security purposes). Making it impossible to dispatch and trigger the benchmark suite (requires authentication from secrets).

References

…h trigger benchmark suite

npm-deploy-user · 2020-01-13T17:29:37Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	41s	36.4s	✅	39.5s	37s	✅	34.5s	30.7s	✅	28.1s	23.2s	✅	33.5s	29.9s	✅
repeat install	9.6s	7.9s	✅	8.6s	7.8s	✅	8.3s	7.7s	✅	7.7s	6.5s	✅	9.1s	7.9s	✅
with warm cache	32.3s	27.8s	✅	33.8s	30.4s	✅	31.3s	27.8s	✅	23.4s	21.7s	✅	29.1s	25.2s	✅
with node_modules	9.2s	7.9s	✅	8.6s	7s	✅	9s	8.2s	✅	7.8s	6.5s	✅	9.4s	8.1s	✅
with lockfile	32.6s	26.1s	✅	31s	29.7s	✅	29s	29.6s	✅🐌	21.7s	19.1s	✅	27.4s	23.7s	✅
with warm cache and node_modules	9.3s	8.2s	✅	7.9s	6.7s	✅	8.4s	8.2s	✅	7.6s	7.5s	✅	9.2s	7.9s	✅
with warm cache and lockfile	24.7s	22.7s	✅	26.3s	25.4s	✅	24.3s	19.9s	✅	17.8s	15.4s	✅	21.3s	20.1s	✅
with node_modules and lockfile	10.1s	9.5s	✅	9.8s	8s	✅	8.6s	7.9s	✅	7.8s	7s	✅	9.7s	8.7s	✅

isaacs · 2020-01-25T00:11:37Z

This looks fine to me, but I am not familiar enough with the benchmarking code to really be a great judge here.

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

@mikemimik

…m support PR-URL: #699 Credit: @mikemimikClose: #699 Reviewed-by: @mikemimik PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

fix: removed authorization header from benchmark dispatch request
fbac8ba

mikemimik added semver:patch semver patch level for changes Enhancement new feature or improvement Release 6.x work is associated with a specific npm 6 release labels Jan 13, 2020

mikemimik requested a review from a team as a code owner January 13, 2020 17:00

feat: added workflow file for commenting on a pull-request to dispatc…
0abdef5
…h trigger benchmark suite

mikemimik force-pushed the feature/benchmarks-v2 branch from 4de8a7d to b62825eCompare January 13, 2020 17:01

mikemimik changed the title ~~Feature/benchmarks v2~~feature/benchmarks-v2Jan 13, 2020

mikemimik self-assigned this Jan 13, 2020

feat: updated workflow for pull-ruquest benchmark dispatch requests
ef13d25

mikemimik force-pushed the feature/benchmarks-v2 branch from b62825e to ef13d25Compare January 13, 2020 17:16

mikemimik mentioned this pull request Jan 13, 2020
Update ci.yml to send correct payload information to benchmark repo npm/benchmarks#3
Closed

mikemimik force-pushed the feature/benchmarks-v2 branch 2 times, most recently from 567f3dd to 1845318Compare January 14, 2020 19:48

darcyclarke added this to the OSS - Sprint 2 milestone Jan 14, 2020

mikemimik force-pushed the feature/benchmarks-v2 branch 3 times, most recently from 4aa23c5 to b22e255Compare January 15, 2020 23:42

docs: updated the CONTRIBUTING file; added references to benchmarking
a6d80af

mikemimik force-pushed the feature/benchmarks-v2 branch from b22e255 to a6d80afCompare January 15, 2020 23:50

mikemimik changed the title ~~feature/benchmarks-v2~~Benchmarks / Contributing UpdatesJan 16, 2020

mikemimik pushed a commit that referenced this pull request Jan 27, 2020
docs: updated the CONTRIBUTING file; added references to benchmarking
95bba6e
PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

darcyclarke approved these changes Jan 28, 2020
View reviewed changes

mikemimik pushed a commit that referenced this pull request Jan 28, 2020
docs: updated the CONTRIBUTING file; added references to benchmarking
fbd042f
PR-URL: #689 Credit: @mikemimikClose: #689 Reviewed-by: @mikemimik

mikemimik closed this in 68fc88eJan 28, 2020

claudiahdz deleted the feature/benchmarks-v2 branch March 30, 2020 23:04

This was referenced Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities hojatA1/npm.cli#91
Open
[Snyk] Fix for 1 vulnerabilities hojatA1/npm.cli#93
Open

EMWickd mentioned this pull request Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities EMWickd/cli#89
Open

Billywildhig mentioned this pull request Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities Billywildhig/cli#63
Open

311821105 mentioned this pull request Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities 311821105/cli#53
Open

Billywildhig mentioned this pull request Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities Billywildhig/cli#65
Open

hojatA1 mentioned this pull request Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities hojatA1/npm.cli#101
Open

EMWickd mentioned this pull request Feb 11, 2024
[Snyk] Fix for 1 vulnerabilities EMWickd/cli#96
Open

This was referenced Feb 12, 2024
[Snyk] Fix for 1 vulnerabilities Billywildhig/cli#73
Open
[Snyk] Fix for 1 vulnerabilities Billywildhig/cli#76
Open

nicholaschoi168 mentioned this pull request Feb 12, 2024
[Snyk] Fix for 1 vulnerabilities nicholaschoi168/cli#25
Open

f4lco0n mentioned this pull request Feb 12, 2024
[Snyk] Fix for 1 vulnerabilities f4lco0n/npm-cli#37
Open

EMWickd mentioned this pull request Feb 12, 2024
[Snyk] Fix for 1 vulnerabilities EMWickd/cli#102
Open

snyk-ioBot mentioned this pull request Oct 22, 2024
[Snyk] Fix for 21 vulnerabilities Graybar-codespace/cli-3#100
Open