Skip to content

fix: npm link does not respect --no-save - #6910

Merged
wraithgar merged 10 commits into
npm:latestfrom
Santoshraj2:issue/3619-no-save
Oct 31, 2023
Merged

fix: npm link does not respect --no-save#6910
wraithgar merged 10 commits into
npm:latestfrom
Santoshraj2:issue/3619-no-save

Conversation

@Santoshraj2

Copy link
Copy Markdown
Contributor

Issue: #3619
there was no condition to capture no-save scenario, read that from CLI and included condition to check that which will end up not saving anything if -no-save is passed as arguments.

@Santoshraj2
Santoshraj2 requested a review from a team as a code ownerOctober 17, 2023 17:39
Comment threadlib/commands/link.js Outdated
Comment threadtest/lib/commands/link.js Outdated
Comment threadtest/lib/commands/link.js Outdated
Comment threadtest/lib/commands/link.js Outdated
@wraithgar

Copy link
Copy Markdown
Contributor

It looks like we may be hitting coverage by accident here. I would expect a test that sets save to false, and has find return cli, and then assert that it is not saved.

Comment threadtest/lib/commands/link.js Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Santoshraj2@wraithgar