Uh oh!
There was an error while loading. Please reload this page.
Config factory - #6912
Closed
wesleytodd wants to merge 2 commits into
Closed
Conversation
wraithgar
commented
Oct 17, 2023
Contributor
After discussing on openjs slack we're gonna prefer that these are defaulted in the constructor instead of needing a new static factory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6911
Helper method to just do this for folks. Thought it was an easy enough addition to just PR it without discussion (or tests lol). Let me know if you don't think this is a good idea.
References