Uh oh!
There was an error while loading. Please reload this page.
fix: add back bin/node-gyp-bin/node-gyp files - #6932
Merged
Conversation
lukekarrysforce-pushed
the
lk/node-gyp-bin-revert
branch
from
October 25, 2023 16:55
65fdee3 to
565b678Comparewraithgar
approved these changes
Oct 25, 2023
wraithgar
left a comment
Contributor
There was a problem hiding this comment.
Land it when it's green.
Merged
lukekarrys added a commit
that referenced
this pull request
Oct 30, 2023
This is a continuation of #6932. This makes a few more changes identified in also porting these changes to v10.
lukekarrys added a commit
that referenced
this pull request
Oct 30, 2023
This is a continuation of #6932. This makes a few more changes identified in also porting these changes to v10.
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an unintended breaking change as part of #6554. The
node-gypbin files are not used by the CLI directly but they are relied on by
other tooling. This change is only intended to land on the v9 release
line.
This partially reverts commit 3a7378d.