Skip to content

fix(unpublish): bubble up all errors parsing local package.json - #7049

Merged
wraithgar merged 1 commit into
latestfrom
gar/unpublish-package-json-errors
Dec 1, 2023
Merged

fix(unpublish): bubble up all errors parsing local package.json#7049
wraithgar merged 1 commit into
latestfrom
gar/unpublish-package-json-errors

Conversation

@wraithgar

Copy link
Copy Markdown
Contributor

If the file is there and there is any error that's always a show stopper

@wraithgar
wraithgar requested a review from a team as a code ownerDecember 1, 2023 18:38
@wraithgar

Copy link
Copy Markdown
ContributorAuthor

@wraithgar
wraithgarforce-pushed the gar/unpublish-package-json-errors branch from e93d3ef to 3a42cffCompareDecember 1, 2023 18:40
If the file is there and there is any error that's always a show stopper
@wraithgar
wraithgarforce-pushed the gar/unpublish-package-json-errors branch from 3a42cff to 82809a9CompareDecember 1, 2023 18:40
@wraithgarwraithgar mentioned this pull request Dec 1, 2023

@hashtagchrishashtagchris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

Comment threadlib/commands/unpublish.js
Comment threadtest/lib/commands/unpublish.js
@wraithgar
wraithgar merged commit 7b952f6 into latestDec 1, 2023
@wraithgar
wraithgar deleted the gar/unpublish-package-json-errors branch December 1, 2023 19:44
@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2023
wraithgar added a commit that referenced this pull request Dec 1, 2023
If the file is there and there is any error that's always a show stopper
wraithgar added a commit that referenced this pull request Dec 1, 2023
If the file is there and there is any error that's always a show stopper
@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wraithgar@hashtagchris