fix: file dependency is locked without name

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602

[sonallux]

This PR currently only contains a reproduction test case for #6430. I have looked into it a bit, but was unable to find a fix for the issue.

It seems like this condition is causing the issue. Because on the first npm install or reify() call the condition is not met because node.packageName and node.name are both equal to @test/a and therefore node.name is not set for the file:a dependency. But on the second npm install or reify() call the condition is met because node.packageName is equal to @test/a and node.name is equal to a. Therefore, the node.name is set to @test/a and the package-lock.json will change.

cli/workspaces/arborist/lib/shrinkwrap.js

Lines 232 to 238 in d04111d

	// we only include name if different from the node path name, and for the
	// root to help prevent churn based on the name of the directory the
	// project is in
	constpname=node.packageName
	if(pname&&(node===node.root||pname!==node.name)){
	meta.name=pname
	}

Can someone help me to fix this issue?

References

Fixes#6430

[sonallux]

Im closing this as the bug has been fixed in #7602