Skip to content

Emit timers via proc-log - #7378

Merged
lukekarrys merged 3 commits into
latestfrom
lk/proc-log-time
Apr 16, 2024
Merged

Emit timers via proc-log#7378
lukekarrys merged 3 commits into
latestfrom
lk/proc-log-time

Conversation

@lukekarrys

@lukekarryslukekarrys commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

This is ready for review but I'm keeping it in draft until #7373 lands as it is based off that.

TODO:

@lukekarryslukekarrys changed the title lk/proc log timeEmit timers via proc-logApr 15, 2024
@lukekarryslukekarrys mentioned this pull request Apr 16, 2024
3 tasks
@lukekarrys
lukekarrysforce-pushed the lk/proc-log-deps branch 2 times, most recently from 5ce9e08 to 0bd87c4CompareApril 16, 2024 15:17
Base automatically changed from lk/proc-log-deps to latestApril 16, 2024 15:58
@lukekarrys
lukekarrys marked this pull request as ready for review April 16, 2024 16:01
@lukekarrys
lukekarrys requested a review from a team as a code ownerApril 16, 2024 16:01
if (npm) {
for (const [name, timer] of npm.unfinishedTimers) {
log.verbose('unfinished npm timer', name, timer)
log.silly('unfinished npm timer', name, timer)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukekarrys
lukekarrys merged commit 38ed048 into latestApr 16, 2024
@lukekarrys
lukekarrys deleted the lk/proc-log-time branch April 16, 2024 16:35
@github-actionsgithub-actionsBot mentioned this pull request Apr 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lukekarrys@wraithgar