Skip to content

chore: reduce windows shim test flakes - #7386

Merged
lukekarrys merged 19 commits into
latestfrom
lk/windooooooooooooooooooooooows
Apr 19, 2024
Merged

chore: reduce windows shim test flakes#7386
lukekarrys merged 19 commits into
latestfrom
lk/windooooooooooooooooooooooows

Conversation

@lukekarrys

@lukekarryslukekarrys commented Apr 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Uses rimraf.moveRemove to delete node.exe since this is the least error-prone way to make sure it doesn't throw when tap is cleaning it up
  • Always use shell: true when running spawnSync

Not merging this until I get 3 consecutive successful CI runs

@lukekarrys
lukekarrysforce-pushed the lk/windooooooooooooooooooooooows branch from 22e7b69 to d736700CompareApril 18, 2024 20:41
@lukekarrys
lukekarrysforce-pushed the lk/windooooooooooooooooooooooows branch from d736700 to 0e5be1aCompareApril 18, 2024 20:42
@lukekarrys
lukekarrys marked this pull request as ready for review April 18, 2024 23:55
@lukekarrys
lukekarrys requested a review from a team as a code ownerApril 18, 2024 23:55
@lukekarryslukekarrys changed the title chore: try to reduce windows shim test flakeschore: reduce windows shim test flakesApr 18, 2024
wraithgar
wraithgar reviewed Apr 19, 2024
View reviewed changes
Comment threadtest/bin/windows-shims.js Outdated
@lukekarrys@wraithgar
Update windows-shims.js
5430f76
Co-authored-by: Gar <gar+gh@danger.computer>
@lukekarrys
lukekarrys merged commit 9333e9d into latestApr 19, 2024
@lukekarrys
lukekarrys deleted the lk/windooooooooooooooooooooooows branch April 19, 2024 01:11
@github-actionsgithub-actionsBot mentioned this pull request Apr 19, 2024
Merged
@npm-cli-botnpm-cli-bot mentioned this pull request Apr 25, 2024
Closed
@npm-cli-botnpm-cli-bot mentioned this pull request Apr 30, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wraithgarwraithgarwraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukekarrys@wraithgar