edit: scoped packages by larsgw · Pull Request #75 · npm/cli

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw · 2018-10-03T18:49:28Z

handle scoped packages properly
change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js+++ b/lib/edit.js@@ -21,7 +21,7 @@ function edit (args, cb) {
"No editor set. Set the 'editor' config, or $EDITOR environ."
))
}
- p = p.split('/')+ p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
.join('/node_modules/')
.replace(/(\/node_modules)+/, '/node_modules')
var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

iarna

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

iarna · 2018-10-04T17:42:17Z


 module.exports = edit
-edit.usage = 'npm edit <pkg>[@<version>]'
+edit.usage = 'npm edit <pkg>[/<subpkg>...]'


I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.
I would like to see the summary in doc/cli/npm-edit.md updated to match!

Will do, didn't see those were in the repo too.

iarna · 2018-10-04T17:45:18Z

 ))
 }
 p = p.split('/')
+ // combine scoped parts


Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

larsgw · 2018-10-24T10:03:20Z

Ping? I added the docs, is there something else?

@larsgw

* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

* fix: enable APIs individually and surface gcloud errors Previously, `gws auth setup` used a single batch `gcloud services enable` call for all 22 Workspace APIs. If any one API failed, the entire batch was marked as failed. Additionally, stderr was piped to /dev/null, so users never saw why APIs failed to enable. Changes: - Enable each API individually so one failure doesn't block the rest - Capture stderr from gcloud and include error messages in output - Show failure details with ⚠ warnings in the wizard status - Include structured error objects in JSON output (apis_failed array) Fixesnpm#75 * address review: parallelize API enablement with tokio, remove clone - Use tokio::process::Command + futures_util::stream::buffer_unordered(5) for parallel, non-blocking API enablement - Remove unnecessary failed_apis.clone() by moving into ctx.failed first - Add changeset * test: add coverage for enable_apis and JSON output structure - test_enable_apis_all_already_enabled: empty input returns empty results - test_enable_apis_with_invalid_project: verifies errors are captured (not swallowed) - test_failed_apis_json_structure: validates {api, error} JSON shape - test_failed_apis_json_empty: empty failures produce empty array * Update src/setup.rs Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

larsgw added 2 commits October 3, 2018 20:36

edit: fix handling of scoped packages
dc01118

edit: fix usage info
441aaaf

larsgw requested a review from a team as a code owner October 3, 2018 18:49

iarna approved these changes Oct 4, 2018
View reviewed changes

docs: fix docs for the npm-edit command
7172364

zkat changed the base branch from latest to release-nextNovember 13, 2018 15:02

zkat added the semver:patch semver patch level for changes label Nov 13, 2018

zkat merged commit a34246b into npm:release-nextNov 26, 2018

zkat pushed a commit that referenced this pull request Dec 10, 2018
edit: scoped packages (#75)
e818cd4
* edit: fix handling of scoped packages * edit: fix usage info * docs: fix docs for the npm-edit command PR-URL: #75 Credit: @larsgw Reviewed-By: @iarna

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jun 24, 2026
📊 대시보드 데이터 업데이트 (npm#75)
76e5c9b

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 1, 2026
🤖 봇 응답 (npm#75)
daac090

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 10, 2026
🔧 자동 수리 완료 (npm#75)
b87dab7

github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 1, 2026
🔥 트렌드 선점 후보 갱신 (npm#75)
a887a2b