Uh oh!
There was an error while loading. Please reload this page.
fix(refactor): use output buffer and error for more commands - #7513
Merged
Conversation
Collaborator
no statistically significant performance changes detected timing results
|
lukekarrysforce-pushed
the
lk/publish-output-buffer
branch
3 times, most recently
from
May 13, 2024 02:59
deb96a5 to
71d5e0aComparelukekarrysforce-pushed
the
lk/errors-and-json
branch
from
May 13, 2024 03:01
1bdb860 to
db68fd2Comparelukekarrysforce-pushed
the
lk/publish-output-buffer
branch
from
May 13, 2024 04:28
71d5e0a to
c462312Comparelukekarrysforce-pushed
the
lk/errors-and-json
branch
from
May 13, 2024 05:29
350d3c1 to
9e3cae2Comparelukekarrysforce-pushed
the
lk/publish-output-buffer
branch
2 times, most recently
from
May 13, 2024 06:31
872be60 to
2d0eb9dComparelukekarrysforce-pushed
the
lk/publish-output-buffer
branch
from
May 13, 2024 07:01
2d0eb9d to
5363c9fComparelukekarrysforce-pushed
the
lk/publish-output-buffer
branch
9 times, most recently
from
May 14, 2024 17:02
75a3c10 to
3a62c37CompareThis changes a bunch of commands to use the new `output.buffer` capabilities from `proc-log` as well as the `outputError` helper from `utils/output-error.js`. There is some new behavior around `run-script` and how it outputs errors. It now displays the error for each workspace similar to how that error would get displayed when the process exits.
lukekarrysforce-pushed
the
lk/publish-output-buffer
branch
from
May 14, 2024 17:10
3a62c37 to
1d64884Comparelukekarrys
marked this pull request as ready for review
May 14, 2024 17:12
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lukekarrysforce-pushed
the
lk/publish-output-buffer
branch
from
May 15, 2024 18:53
80e6de4 to
9da2d27Comparelukekarrysforce-pushed
the
lk/publish-output-buffer
branch
from
May 15, 2024 19:11
9da2d27 to
11a49f9Comparewraithgar
approved these changes
May 15, 2024
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a bunch of commands to use the new
output.buffercapabilities fromproc-logas well as theoutputErrorhelper fromutils/output-error.js.This also adds a few comments about future display related breaking changes that npm should make.
There is some new behavior around
run-scriptand how it outputs errors. It now displays the error for each workspace similar to how that error would get displayed when the process exits.Here are some screenshots of the new
run-scriptoutput to show with coloring. These are all represented in snapshots as well both those can be hard to decipher with ansi codes. The screenshots are run viaset -x; npm $@; npmlocal $@so the output preceded with+ npmis just to show the command being run.Running a non-existent command from multiple workspaces

Running a script that errors from multiple workspaces

Listing scripts
The only change here is I removed the newline between lifecycle scripts and run scripts. I find the indent shows the hierarchy of information and the extra newline made it difficult to quickly scan multiple workspaces which are also separated by newlines.