Skip to content

fix(view): refactor exec and execWorkspaces to call same methods - #7520

Merged
lukekarrys merged 1 commit into
latestfrom
lk/view-refactor
May 14, 2024
Merged

fix(view): refactor exec and execWorkspaces to call same methods#7520
lukekarrys merged 1 commit into
latestfrom
lk/view-refactor

Conversation

@lukekarrys

Copy link
Copy Markdown
Contributor

Also cleanup json mode to not stringify and parse unnecessarily

@lukekarrys
lukekarrys requested a review from a team as a code ownerMay 13, 2024 21:23
Also cleanup `json` mode to not stringify and parse unnecessarily
@npm-cli-bot

npm-cli-bot commented May 13, 2024

Copy link
Copy Markdown
Collaborator

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlymodules-onlyno-lockno-cacheno-modulesno-cleanshow-versionrun-scriptcache-only
peer-deps
no-clean
audit
npm@latest33.479 ±1.2310.645 ±0.0311.802 ±0.161.555 ±0.031.550 ±0.011.295 ±0.008.250 ±0.021.281 ±0.010.139 ±0.000.167 ±0.0013.512 ±0.183.920 ±2.63
#752032.625 ±0.5510.647 ±0.0111.727 ±0.021.555 ±0.011.555 ±0.021.270 ±0.008.238 ±0.051.282 ±0.010.138 ±0.000.167 ±0.0014.867 ±0.052.247 ±0.20
app-mediumcleanlock-onlycache-onlymodules-onlyno-lockno-cacheno-modulesno-cleanshow-versionrun-scriptcache-only
peer-deps
no-clean
audit
npm@latest26.238 ±2.477.963 ±0.008.941 ±0.081.531 ±0.011.507 ±0.011.435 ±0.035.846 ±0.021.325 ±0.010.140 ±0.000.167 ±0.009.515 ±0.153.139 ±1.63
#752025.652 ±0.887.976 ±0.028.938 ±0.001.536 ±0.011.538 ±0.021.435 ±0.016.001 ±0.001.354 ±0.010.147 ±0.000.175 ±0.0010.181 ±0.312.021 ±0.05

@lukekarrys
lukekarrys merged commit 76aef74 into latestMay 14, 2024
@lukekarrys
lukekarrys deleted the lk/view-refactor branch May 14, 2024 14:34
@github-actionsgithub-actionsBot mentioned this pull request May 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@npm-cli-bot@wraithgar